Closed Bug 706560 Opened 8 years ago Closed 8 years ago

Send MOZ_APP_ID to crash reporter

Categories

(Toolkit :: Crash Reporting, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: dougt, Assigned: dougt)

References

Details

Attachments

(1 file)

Fennec using XUL and Fennec using android's native toolkit (Java) both have the same MOZ_APP_NAME.  They are both Fennec.  When a new platform comes out -- say windows phone -- and we want to port to Fennec, that application will also have the same MOZ_APP_NAME.

So, in order to separate these "different" applications, we want to use the MOZ_APP_ID.  This value is currently used by addons.  We want to send this value to the crash server so that they can key on this value.
Component: Build Config → Breakpad Integration
Product: Core → Toolkit
QA Contact: build-config → breakpad.integration
Given the formatting of other values I have looked up in the code, I think we should use "AppID" or "AddonsAppId" for that parameter to send with crash reports (given that its original purpose is an identifier for add-ons, the latter might make sense).
Blocks: 706612
When we are preparing to introduct a new app id, please make sure that a bug is filed with metrics as well since we will not automatically report on it unless we are notified.
ted: we are proceeding with this ASAP.  Please let me know when it's done.
We are going to use "ProductID" as the key.


This is consistent with the naming and case of other uses:

http://mxr.mozilla.org/mozilla-central/ident?i=AnnotateCrashReport
Assignee: nobody → doug.turner
Attached patch patch v.1Splinter Review
Attachment #578363 - Flags: review?(ted.mielczarek)
Comment on attachment 578363 [details] [diff] [review]
patch v.1

Sorry I didn't get to this, I had some family stuff come up today. This looks like exactly what I was going to do..
Attachment #578363 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/mozilla-central/rev/13185042410d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.