706560 - Send MOZ_APP_ID to crash reporter

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Doug Turner (:dougt)]

Fennec using XUL and Fennec using android's native toolkit (Java) both have the same MOZ_APP_NAME.  They are both Fennec.  When a new platform comes out -- say windows phone -- and we want to port to Fennec, that application will also have the same MOZ_APP_NAME.

So, in order to separate these "different" applications, we want to use the MOZ_APP_ID.  This value is currently used by addons.  We want to send this value to the crash server so that they can key on this value.

Comment 1

[Robert Kaiser]

Given the formatting of other values I have looked up in the code, I think we should use "AppID" or "AddonsAppId" for that parameter to send with crash reports (given that its original purpose is an identifier for add-ons, the latter might make sense).

Comment 2

[Daniel Einspanjer [:dre] [:deinspanjer]]

When we are preparing to introduct a new app id, please make sure that a bug is filed with metrics as well since we will not automatically report on it unless we are notified.

Comment 3

[Laura Thomson :laura]

ted: we are proceeding with this ASAP.  Please let me know when it's done.

Comment 4

[Doug Turner (:dougt)]

We are going to use "ProductID" as the key.


This is consistent with the naming and case of other uses:

http://mxr.mozilla.org/mozilla-central/ident?i=AnnotateCrashReport

Comment 5

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 578363 [details] [diff] [review]
patch v.1

Sorry I didn't get to this, I had some family stuff come up today. This looks like exactly what I was going to do..

Comment 7

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/13185042410d

Comment 8

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/13185042410d