Closed
Bug 706682
Opened 13 years ago
Closed 13 years ago
don't access bgra[4]
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla11
People
(Reporter: espindola, Assigned: espindola)
References
Details
Attachments
(1 file, 1 obsolete file)
1.92 KB,
patch
|
jaas
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•13 years ago
|
Summary: don't access element -1 → don't access bgra[5]
Assignee | ||
Updated•13 years ago
|
Summary: don't access bgra[5] → don't access bgra[4]
Assignee | ||
Comment 1•13 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=134e95588dc2
Comment on attachment 578121 [details] [diff] [review] fix it Review of attachment 578121 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/plugins/test/testplugin/nptest_utils.cpp @@ +93,5 @@ > parseHexColor(const char* color, int len) > { > PRUint8 bgra[4] = { 0, 0, 0, 0xFF }; > int i = 0; > + assert(len == 9); The description for this function strongly implies that the length does not have to be a full nine characters.
Assignee | ||
Comment 3•13 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=5095ce6e2f05
Attachment #578121 -
Attachment is obsolete: true
Attachment #578121 -
Flags: review?(ehsan)
Attachment #578143 -
Flags: review?(joshmoz)
Assignee | ||
Comment 4•13 years ago
|
||
obviously I forgot a printf in it, I will remove it if the rest of the patch is OK.
Attachment #578143 -
Flags: review?(joshmoz) → review+
Assignee | ||
Comment 5•13 years ago
|
||
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=4835dc9b8fc7
Comment 6•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4835dc9b8fc7
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•