706717 - icongrid bug in attempting to use createGrid

Status: VERIFIED FIXED

(Web Apps :: Dashboard, defect, P1)

Description

[[e-mail] [:onecyrenus]]

var imgURL = theItem.itemImgURL;
icongrid.js:937 Uncaught TypeError: Cannot read property 'itemImgURL' of undefined
    //if it doesn't, ask the datasource for it
    if (!imgURL && self.datasource.getItemImgURL) {
      imgURL = self.datasource.getItemImgURL(Base32.decode(guid));
    }
    //if we still don't have one, use a generic gray icon as a placeholder
    if (!imgURL) {
      imgURL = 
    }

Basic exception is being thrown on the manifest, prevents the rest of the icons from being shown.

Comment 1

[[e-mail] [:onecyrenus]]

There is an issue of localStorage being corrupted, and then preventing dashboard from being displayed.  

I have seen the case where the guid is coming up null, and that prevents the rest of the icons from being shown.  

There probably needs to be some sort of exception handling mechanism so one icon doesn't stop the display of all icons.

Comment 2

[[e-mail] [:onecyrenus]]

Mohamed also experienced this same phenomena today.

Comment 3

[Bill Walker [:bwalker] [@wfwalker]]

Per Dan, marking as P1, this is a blocker for Apps Dev Preview release

Comment 4

[Dan Walkowski]

Although I was unable to replicate the problem, I inspected the code in the vicinity that David mentioned, and can see how bad things could happen there.  I have checked in better error handling code in and near that portion of the code, which I think should fix the problem.  Please reopen this bug if that turns out not to be the case.

Comment 5

[Anant Narayanan [:anant]]

FIxed in https://github.com/mozilla/icongrid/commit/88b97962b62a6f77aff8a104f4ab66922c2a8216