Don't evaluate static blocklists and special cases during evaluation of downloaded blocklist

RESOLVED FIXED in mozilla11

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: drs, Assigned: drs)

Tracking

Trunk
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
bug 693813 fixed this issue previously, but I reintroduced this bug in 668004. Basically, we have to avoid evaluating any special cases or static blocklist entries when evaluating the downloaded blocklist. We don't want to pref things off if they're already compiled in as being blocked.
(Assignee)

Updated

6 years ago
Blocks: 706702
(Assignee)

Comment 1

6 years ago
Created attachment 578497 [details] [diff] [review]
Patch v1.0, don't evaluate static blocklists and special cases during evaluation of dowloaded blocklist.

See bug description.
Assignee: nobody → dsherk
Attachment #578497 - Flags: review?(joe)
(Assignee)

Comment 2

6 years ago
Try push: https://tbpl.mozilla.org/?tree=Try&rev=abe278c327db
Comment on attachment 578497 [details] [diff] [review]
Patch v1.0, don't evaluate static blocklists and special cases during evaluation of dowloaded blocklist.

Review of attachment 578497 [details] [diff] [review]:
-----------------------------------------------------------------

It'll need rebasing after making changes to dependent patches, but looks good.
Attachment #578497 - Flags: review?(joe) → review+
(Assignee)

Comment 4

6 years ago
Created attachment 579852 [details] [diff] [review]
Patch v1.1, don't evaluate static blocklists and special cases during evaluation of dowloaded blocklist.

Removed comments/old code, +r carried.
Attachment #578497 - Attachment is obsolete: true
Attachment #579852 - Flags: review+
(Assignee)

Comment 5

6 years ago
https://tbpl.mozilla.org/?rev=fe937bac6e75
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

6 years ago
https://hg.mozilla.org/mozilla-central/rev/49b8bec6d175
Target Milestone: --- → mozilla11
Backed out from beta only:
http://hg.mozilla.org/releases/mozilla-beta/rev/2fccf5e774a7
See bug 711656 for explanation.
You need to log in before you can comment on or make changes to this bug.