706886 - Line-through disappears after editing overridden rule in style inspector

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Heather Arthur [:harth]]

If you edit an overridden rule in the ruleview the line-through / strikeout indicator disappears. The line-through should be re-applied after editing the rule.

Comment 1

[Dave Camp (:dcamp)]

So it does, weird.

Comment 2

[Dave Camp (:dcamp)]

Attachment: fix

Fairly straightforward:

* During refresh, TextPropertyEditor hides the strikethrough while editing (to avoid looking strange) by checking if there's an active editor on its spans.
* inplace editor was calling done() callback before tearing itself down.
* done() indirectly causes a refresh (good) which saw a still-active editor (bad).

Attached patch tears down the editor before calling the done() callback.

Comment 3

[Joe Walker [:jwalker]]

Comment on attachment 579906 [details] [diff] [review]
fix

Review of attachment 579906 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/styleinspector/CssRuleView.jsm
@@ +1284,1 @@
>      }

This is a blatant 'to prove i read it' comment:

this._clear();
if (typeof this.done == "function") {
  let value = this.cancelled ? this.initial : this.input.value.trim();
  this.done(value, !this.cancelled);
}

It's 0.0002ms faster in the case when this.done isn't set, and it doesn't crash if this.done is set incorrectly, and it read easier to me, and I really don't care if you ignore me.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Bug triage, filter on PEGASUS.

Comment 5

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 579906 [details] [diff] [review]
fix

yeah, sure thing.

Comment 6

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/b8281fe1b926

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/b8281fe1b926

Comment 8

[Heather Arthur [:harth]]

Unfortunately, this is happening again.

Comment 9

[Dave Camp (:dcamp)]

Not sure when I can get to this, so assigning to default in case someone else wants to pick it up.

Comment 10

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Patch

Simple fix. Use linethrough if we should when the value is overridden.

We were displaying as overridden when the name was changed, but not the value.

Comment 11

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://hg.mozilla.org/integration/fx-team/rev/a5c189768303

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/a5c189768303