Closed Bug 706984 Opened 12 years ago Closed 12 years ago

NullPointerException @ getProfileDir(GeckoApp.java:705) on startup (thrown but caught)

Categories

(Firefox for Android Graveyard :: General, defect, P3)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect

Tracking

(firefox11 fixed, fennec11+)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox11 --- fixed
fennec 11+ ---

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

check-profile-directory.patch
1.16 KB, patch
dougt
: review+
Details | Diff | Splinter Review 
Fennec throws the following NullPointerException on startup because 

12-01 13:09:40.415: I/GeckoAddons(6017): error reading json file
12-01 13:09:40.415: I/GeckoAddons(6017): java.lang.NullPointerException
12-01 13:09:40.415: I/GeckoAddons(6017): 	at org.mozilla.gecko.GeckoApp.getProfileDir(GeckoApp.java:705)
12-01 13:09:40.415: I/GeckoAddons(6017): 	at org.mozilla.gecko.AboutHomeContent.getProfileRecommendedAddonsStream(AboutHomeContent.java:157)
12-01 13:09:40.415: I/GeckoAddons(6017): 	at org.mozilla.gecko.AboutHomeContent.getRecommendedAddonsStream(AboutHomeContent.java:171)
12-01 13:09:40.415: I/GeckoAddons(6017): 	at org.mozilla.gecko.AboutHomeContent$4.run(AboutHomeContent.java:185)
12-01 13:09:40.415: I/GeckoAddons(6017): 	at android.os.Handler.handleCallback(Handler.java:587)
12-01 13:09:40.415: I/GeckoAddons(6017): 	at android.os.Handler.dispatchMessage(Handler.java:92)
12-01 13:09:40.415: I/GeckoAddons(6017): 	at android.os.Looper.loop(Looper.java:130)
12-01 13:09:40.415: I/GeckoAddons(6017): 	at org.mozilla.gecko.GeckoAppShell$LooperThread.run(GeckoAppShell.java:153)

This code was added by changeset:

changeset:   81469:66f5729d323c
user:        Brad Lassey <blassey@mozilla.com>
date:        Wed Nov 30 21:28:05 2011 -0500
files:       mobile/android/base/GeckoApp.java mobile/android/base/GeckoAppShell.java
description:
bug 706393 - Add API to GeckoApp to get profile dir r=mfinkle
Note that the NullPointerException is caught and does not crash the app.
Summary: NullPointerException at getProfileDir(GeckoApp.java:705) on startup → NullPointerException @ getProfileDir(GeckoApp.java:705) on startup (thrown but caught)
Severity: normal → critical
Keywords: crash
OS: Mac OS X → Android
Hardware: x86 → ARM
Whiteboard: [native-crash]
Woops disregard above
Severity: critical → normal
Keywords: crash
Whiteboard: [native-crash]
Assignee: nobody → blassey.bugs
Assignee: blassey.bugs → cpeterson
Priority: -- → P3
Status: NEW → ASSIGNED
Check whether the profile directory exists before enumerating its contents. The profile directory may have been deleted or not created yet.
Attachment #580585 - Flags: review?(doug.turner)
Attachment #580585 - Flags: review?(doug.turner) → review+
https://hg.mozilla.org/mozilla-central/rev/71dfb2adaf0f
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
tracking-fennec: --- → 11+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.