Closed Bug 707014 Opened 8 years ago Closed 8 years ago

JavaScript Error: "frame.frameElement is null" {file: "chrome://browser/content/browser.js" line: 1856}

Categories

(Firefox for Android :: General, defect, major)

All
Android
defect
Not set
major

Tracking

()

VERIFIED FIXED

People

(Reporter: fabrice, Assigned: mfinkle)

Details

Attachments

(1 file)

STR:
1) Open http://people.mozilla.com/~fdesre/openwebapps/buttons.html
2) tap on buttons
3) open another tab and load a site
4) go back to the buttons.html tab
5) tap on a button

ER:
The button reacts normally

OR:
The button turns yellow (active state) and the error:
JavaScript Error: "frame.frameElement is null" {file: "chrome://browser/content/browser.js" line: 1856} is thrown.
Assignee: nobody → wjohnston
Attached patch patchSplinter Review
"content" was left over from the XUL port. The (frame != content) is used to make sure the frame is not the top-level window. This can be handled by (frame.frameElement) cause frameElement is null for the top-level window.
Assignee: wjohnston → mark.finkle
Attachment #578506 - Flags: review?(wjohnston)
Comment on attachment 578506 [details] [diff] [review]
patch

Review of attachment 578506 [details] [diff] [review]:
-----------------------------------------------------------------

Whoops. Awesome. Thank you. And nice catch. All at once.
Attachment #578506 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/projects/birch/rev/513f03d9e371
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Retested with:
Mozilla/5.0 (Android; Linux arm7l; rv:11.0a1) Gecko/20111205 Firefox/11.0a1 Fennec/11.0a1
Device: HTC Desire Z (Android 2.3)

Bug no longer reproducible, no error is displayed. Buttons from http://people.mozilla.com/~fdesre/openwebapps/buttons.html react normally when switching from another tab.

Verifying bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.