Closed Bug 707033 Opened 9 years ago Closed 9 years ago

Kill the hashtables of WebGLUniformLocation's held by WebGLProgram's

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: bjacob, Assigned: bjacob)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch kill mMapUniformLocations (obsolete) — Splinter Review
Currently, WebGLProgram holds a hashtable of refptrs to all WebGLUniformLocation's created from it.

It's used for one thing: to ensure that multiple getUniformLocation() calls on same uniform return the same WebGLUniformLocation object.

However, in a discussion on the public_webgl mailing list this week, we agreed that this was not mandated by the spec and that on the contrary, to ensure consistent behavior across browsers, we're going to require that NOT to happen. So this becomes a conformance issue.

Removing this hashtable also simplifies code and ownership patterns.
Attachment #578440 - Flags: review?(jgilbert)
Attachment #578465 - Flags: review?(jgilbert)
Attachment #578440 - Attachment is obsolete: true
Attachment #578440 - Flags: review?(jgilbert)
Attachment #578465 - Flags: review?(jgilbert) → review+
Depends on: 705904
https://hg.mozilla.org/mozilla-central/rev/432d88a73914
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.