Last Comment Bug 707033 - Kill the hashtables of WebGLUniformLocation's held by WebGLProgram's
: Kill the hashtables of WebGLUniformLocation's held by WebGLProgram's
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Canvas: WebGL (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla11
Assigned To: Benoit Jacob [:bjacob] (mostly away)
:
: Milan Sreckovic [:milan]
Mentors:
Depends on: 705904
Blocks: webgl-conformance
  Show dependency treegraph
 
Reported: 2011-12-01 16:32 PST by Benoit Jacob [:bjacob] (mostly away)
Modified: 2011-12-05 10:21 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
kill mMapUniformLocations (9.18 KB, patch)
2011-12-01 16:32 PST, Benoit Jacob [:bjacob] (mostly away)
no flags Details | Diff | Splinter Review
kill mMapUniformLocations (9.19 KB, patch)
2011-12-01 18:21 PST, Benoit Jacob [:bjacob] (mostly away)
jgilbert: review+
Details | Diff | Splinter Review

Description Benoit Jacob [:bjacob] (mostly away) 2011-12-01 16:32:55 PST
Created attachment 578440 [details] [diff] [review]
kill mMapUniformLocations

Currently, WebGLProgram holds a hashtable of refptrs to all WebGLUniformLocation's created from it.

It's used for one thing: to ensure that multiple getUniformLocation() calls on same uniform return the same WebGLUniformLocation object.

However, in a discussion on the public_webgl mailing list this week, we agreed that this was not mandated by the spec and that on the contrary, to ensure consistent behavior across browsers, we're going to require that NOT to happen. So this becomes a conformance issue.

Removing this hashtable also simplifies code and ownership patterns.
Comment 1 Benoit Jacob [:bjacob] (mostly away) 2011-12-01 16:46:06 PST
https://tbpl.mozilla.org/?tree=Try&rev=16db8f0aa4a8
Comment 2 Benoit Jacob [:bjacob] (mostly away) 2011-12-01 18:21:55 PST
Created attachment 578465 [details] [diff] [review]
kill mMapUniformLocations
Comment 3 Benoit Jacob [:bjacob] (mostly away) 2011-12-03 19:45:35 PST
https://tbpl.mozilla.org/?tree=Try&rev=61fe3434a9aa
Comment 4 Benoit Jacob [:bjacob] (mostly away) 2011-12-04 11:27:47 PST
http://hg.mozilla.org/integration/mozilla-inbound/rev/432d88a73914
Comment 5 Matt Brubeck (:mbrubeck) 2011-12-05 10:21:16 PST
https://hg.mozilla.org/mozilla-central/rev/432d88a73914

Note You need to log in before you can comment on or make changes to this bug.