The default bug view has changed. See this FAQ.

Kill the hashtables of WebGLUniformLocation's held by WebGLProgram's

RESOLVED FIXED in mozilla11

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bjacob, Assigned: bjacob)

Tracking

unspecified
mozilla11
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 578440 [details] [diff] [review]
kill mMapUniformLocations

Currently, WebGLProgram holds a hashtable of refptrs to all WebGLUniformLocation's created from it.

It's used for one thing: to ensure that multiple getUniformLocation() calls on same uniform return the same WebGLUniformLocation object.

However, in a discussion on the public_webgl mailing list this week, we agreed that this was not mandated by the spec and that on the contrary, to ensure consistent behavior across browsers, we're going to require that NOT to happen. So this becomes a conformance issue.

Removing this hashtable also simplifies code and ownership patterns.
Attachment #578440 - Flags: review?(jgilbert)
(Assignee)

Comment 1

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=16db8f0aa4a8
(Assignee)

Comment 2

5 years ago
Created attachment 578465 [details] [diff] [review]
kill mMapUniformLocations
Attachment #578465 - Flags: review?(jgilbert)
(Assignee)

Updated

5 years ago
Attachment #578440 - Attachment is obsolete: true
Attachment #578440 - Flags: review?(jgilbert)
Attachment #578465 - Flags: review?(jgilbert) → review+
Depends on: 705904
(Assignee)

Comment 3

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=61fe3434a9aa
(Assignee)

Comment 4

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/432d88a73914
Assignee: nobody → bjacob
https://hg.mozilla.org/mozilla-central/rev/432d88a73914
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.