Closed Bug 707037 Opened 8 years ago Closed 7 years ago

Revert the update check frequency increase

Categories

(Firefox :: General, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 17
Tracking Status
firefox12 --- fixed
firefox13 --- fixed
firefox14 + fixed
firefox15 + fixed
firefox16 + fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

We need to revert the code bug 707020 adds after the testing of bug 481815 is finished.
Although the testing is not finished, we can probably revert this.
Attached patch Patch (v1)Splinter Review
[Approval Request Comment]
Regression caused by (bug #): No regression, it's just something that we wanted on nightly but not on Aurora.
User impact if declined: Updates checked for more than necessary.
Testing completed (on m-c, etc.): This reverts us to the situation we were in before bug 702020.
Risk to taking this patch (and alternatives if risky): None.
String changes made by this patch: None.
Attachment #593950 - Flags: review?(netzen)
Attachment #593950 - Flags: approval-mozilla-aurora?
Comment on attachment 593950 [details] [diff] [review]
Patch (v1)

Review of attachment 593950 [details] [diff] [review]:
-----------------------------------------------------------------

This reverts it back to the correct old values for Aurora. Looks good.
Attachment #593950 - Flags: review?(netzen) → review+
Sorry I should say:
This reverts it back to the correct old values for Nightly on the Aurora branch. Looks good.
Alex, can we take this on Aurora sooner rather than later please?  Thanks!  :-)
Comment on attachment 593950 [details] [diff] [review]
Patch (v1)

[Triage Comment]
Minor interval change - low risk. Approved for Aurora.
Attachment #593950 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Ehsan: can we close this bug now?
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #8)
> Ehsan: can we close this bug now?

No, I've missed this on Aurora 13, which means that this will be on Beta13 tomorrow.  We need to take the patch on Aurora and Beta again tomorrow, but I'd like to hold off on landing this on central until the work in bug 307181 is finished.
Comment on attachment 593950 [details] [diff] [review]
Patch (v1)

[Approval Request Comment]
Regression caused by (bug #): No regression, it's just something that we wanted on nightly but not on Aurora.
User impact if declined: Updates checked for more than necessary.
Testing completed (on m-c, etc.): This reverts us to the situation we were in before bug 702020.
Risk to taking this patch (and alternatives if risky): None.
String changes made by this patch: None.
Attachment #593950 - Flags: approval-mozilla-beta?
Attachment #593950 - Flags: approval-mozilla-aurora?
Attachment #593950 - Flags: approval-mozilla-aurora+
Comment on attachment 593950 [details] [diff] [review]
Patch (v1)

[Triage Comment]
Approving for Aurora 13 since we may still be able to land this before tomorrow's merge. Feel free to carry over to Beta 13 after the uplift.
Attachment #593950 - Flags: approval-mozilla-beta?
Attachment #593950 - Flags: approval-mozilla-aurora?
Attachment #593950 - Flags: approval-mozilla-aurora+
(In reply to Alex Keybl [:akeybl] from comment #11)
> Comment on attachment 593950 [details] [diff] [review]
> Patch (v1)
> 
> [Triage Comment]
> Approving for Aurora 13 since we may still be able to land this before
> tomorrow's merge. Feel free to carry over to Beta 13 after the uplift.

Sorry if I was vague.  I do not want this on central, which is why I asked for approval on Aurora.  I'll land this on Aurora right now, and will re-request Aurora approval once again after the merge.
Comment on attachment 593950 [details] [diff] [review]
Patch (v1)

Requesting approval for the new Aurora.
Attachment #593950 - Flags: approval-mozilla-aurora+ → approval-mozilla-aurora?
Comment on attachment 593950 [details] [diff] [review]
Patch (v1)

[Triage comment]
approved for the new aurora.
Attachment #593950 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Do we want to do anything here before June 5th?
We need to land this on Aurora after the uplift.  On central, I'd still like to keep this maybe for a couple of more weeks.
Landed for Firefox 16 on Aurora:

http://hg.mozilla.org/releases/mozilla-aurora/rev/8386a8f7289a

Also, time to stop this on Nightly as well:

https://hg.mozilla.org/integration/mozilla-inbound/rev/b4028e63e58b
Target Milestone: --- → Firefox 17
https://hg.mozilla.org/mozilla-central/rev/b4028e63e58b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.