707037 - Revert the update check frequency increase

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[(no longer active)]

We need to revert the code bug 707020 adds after the testing of bug 481815 is finished.

Comment 1

[Brian R. Bondy [:bbondy]]

Although the testing is not finished, we can probably revert this.

Comment 2

[(no longer active)]

Attachment: Patch (v1)

[Approval Request Comment]
Regression caused by (bug #): No regression, it's just something that we wanted on nightly but not on Aurora.
User impact if declined: Updates checked for more than necessary.
Testing completed (on m-c, etc.): This reverts us to the situation we were in before bug 702020.
Risk to taking this patch (and alternatives if risky): None.
String changes made by this patch: None.

Comment 3

[Brian R. Bondy [:bbondy]]

Comment on attachment 593950 [details] [diff] [review]
Patch (v1)

Review of attachment 593950 [details] [diff] [review]:
-----------------------------------------------------------------

This reverts it back to the correct old values for Aurora. Looks good.

Comment 4

[Brian R. Bondy [:bbondy]]

Sorry I should say:
This reverts it back to the correct old values for Nightly on the Aurora branch. Looks good.

Comment 5

[(no longer active)]

Alex, can we take this on Aurora sooner rather than later please?  Thanks!  :-)

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 593950 [details] [diff] [review]
Patch (v1)

[Triage Comment]
Minor interval change - low risk. Approved for Aurora.

Comment 7

[(no longer active)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/111665833e7d

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Ehsan: can we close this bug now?

Comment 9

[(no longer active)]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #8)
> Ehsan: can we close this bug now?

No, I've missed this on Aurora 13, which means that this will be on Beta13 tomorrow.  We need to take the patch on Aurora and Beta again tomorrow, but I'd like to hold off on landing this on central until the work in bug 307181 is finished.

Comment 10

[(no longer active)]

Comment on attachment 593950 [details] [diff] [review]
Patch (v1)

[Approval Request Comment]
Regression caused by (bug #): No regression, it's just something that we wanted on nightly but not on Aurora.
User impact if declined: Updates checked for more than necessary.
Testing completed (on m-c, etc.): This reverts us to the situation we were in before bug 702020.
Risk to taking this patch (and alternatives if risky): None.
String changes made by this patch: None.

Comment 11

[Alex Keybl [:akeybl]]

Comment on attachment 593950 [details] [diff] [review]
Patch (v1)

[Triage Comment]
Approving for Aurora 13 since we may still be able to land this before tomorrow's merge. Feel free to carry over to Beta 13 after the uplift.

Comment 12

[(no longer active)]

(In reply to Alex Keybl [:akeybl] from comment #11)
> Comment on attachment 593950 [details] [diff] [review]
> Patch (v1)
> 
> [Triage Comment]
> Approving for Aurora 13 since we may still be able to land this before
> tomorrow's merge. Feel free to carry over to Beta 13 after the uplift.

Sorry if I was vague.  I do not want this on central, which is why I asked for approval on Aurora.  I'll land this on Aurora right now, and will re-request Aurora approval once again after the merge.

Comment 13

[(no longer active)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2e0d201168b3

Comment 14

[(no longer active)]

Comment on attachment 593950 [details] [diff] [review]
Patch (v1)

Requesting approval for the new Aurora.

Comment 15

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 593950 [details] [diff] [review]
Patch (v1)

[Triage comment]
approved for the new aurora.

Comment 16

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/9a9581a8a539

Comment 17

[Brian R. Bondy [:bbondy]]

Do we want to do anything here before June 5th?

Comment 18

[(no longer active)]

We need to land this on Aurora after the uplift.  On central, I'd still like to keep this maybe for a couple of more weeks.

Comment 19

[(no longer active)]

Ported to the new aurora as well: http://hg.mozilla.org/releases/mozilla-aurora/rev/898a1bd48058

Comment 20

[(no longer active)]

Landed for Firefox 16 on Aurora:

http://hg.mozilla.org/releases/mozilla-aurora/rev/8386a8f7289a

Also, time to stop this on Nightly as well:

https://hg.mozilla.org/integration/mozilla-inbound/rev/b4028e63e58b

Comment 21

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b4028e63e58b