Last Comment Bug 707052 - regression in patch for bug 90268
: regression in patch for bug 90268
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Plug-ins (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
http://pearce.org.nz/full-screen/9026...
Depends on:
Blocks: 90268
  Show dependency treegraph
 
Reported: 2011-12-01 18:34 PST by Josh Aas
Modified: 2012-02-02 09:29 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
local test case (2.58 KB, application/octet-stream)
2011-12-01 18:34 PST, Josh Aas
no flags Details
flawed automated test v1.0 (7.21 KB, patch)
2011-12-01 18:37 PST, Josh Aas
no flags Details | Diff | Review

Description Josh Aas 2011-12-01 18:34:13 PST
Created attachment 578471 [details]
local test case

Chris Pearce found a regression in my patch for bug 90268. I want to give his regression its own bug for tracking purposes.

I'm attaching a zip file with a local test case, but there is also a URL for it.

To reproduce problem with patches in bug 90268:

    Click "Create windowless plugin"
    Click "Add plugin to doc". Observe plugin working.
    Click "Remove plugin".
    Click "Add plugin to doc". Observe plugin not working.
Comment 1 Josh Aas 2011-12-01 18:37:52 PST
Created attachment 578472 [details] [diff] [review]
flawed automated test v1.0

I set out to make an automated test and I succeeded, sort of. It depends on how long the stream takes to load, which means it involves some nasty timeouts that I'm not comfortable checking in. The timeouts approximate the time between clicking buttons in the test case Chris provided.
Comment 2 Josh Aas 2012-02-02 09:29:15 PST
This regression is fixed in the latest version of the patch.

Note You need to log in before you can comment on or make changes to this bug.