The default bug view has changed. See this FAQ.

"ASSERTION: Battery API: When charging and level at 1.0, remaining time should be 0. Please fix your backend!"

RESOLVED FIXED in mozilla11

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jesse Ruderman, Assigned: mounir)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
mozilla11
assertion, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 578510 [details]
testcase

Calling navigator.mozBattery triggers:

###!!! ASSERTION: Battery API: When charging and level at 1.0, remaining time should be 0. Please fix your backend!: 'Error', file dom/battery/BatteryManager.cpp, line 200

My MacBook Pro is fully charged and plugged in.  I am running Mac OS X 10.6.
(Assignee)

Comment 1

5 years ago
Created attachment 578558 [details] [diff] [review]
Patch v1

Oups, I forgot two changes. I guess it was a good idea to put that assertion :)
Assignee: nobody → mounir
Status: NEW → ASSIGNED
Attachment #578558 - Flags: review?(jones.chris.g)
(Assignee)

Comment 2

5 years ago
This should actually apply on all platforms without battery backends (Windows, Mac and Linux without DBus).
OS: Mac OS X → All
Hardware: x86_64 → All
(Assignee)

Comment 3

5 years ago
Comment on attachment 578558 [details] [diff] [review]
Patch v1

Jonas, feel free to take this review from Chris. It's a two-line change (for real this time ;)) and Chris is on vacation AFAIK.
Attachment #578558 - Flags: review?(jonas)
(Assignee)

Updated

5 years ago
Whiteboard: [needs review]
Attachment #578558 - Flags: review?(jonas) → review+
(Assignee)

Comment 4

5 years ago
I marked this in-testsuite+ because technically the mochitests were throwing an assert but we don't fail on them yet.
Flags: in-testsuite+
Whiteboard: [needs review]
Target Milestone: --- → mozilla11
(Assignee)

Updated

5 years ago
Attachment #578558 - Flags: review?(jones.chris.g) → checkin+
https://hg.mozilla.org/mozilla-central/rev/3d2eac7dcf66
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Depends on: 710178
You need to log in before you can comment on or make changes to this bug.