Closed Bug 707085 Opened 8 years ago Closed 8 years ago

"ASSERTION: Battery API: When charging and level at 1.0, remaining time should be 0. Please fix your backend!"

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: jruderman, Assigned: mounir)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(2 files)

Attached file testcase
Calling navigator.mozBattery triggers:

###!!! ASSERTION: Battery API: When charging and level at 1.0, remaining time should be 0. Please fix your backend!: 'Error', file dom/battery/BatteryManager.cpp, line 200

My MacBook Pro is fully charged and plugged in.  I am running Mac OS X 10.6.
Attached patch Patch v1Splinter Review
Oups, I forgot two changes. I guess it was a good idea to put that assertion :)
Assignee: nobody → mounir
Status: NEW → ASSIGNED
Attachment #578558 - Flags: review?(jones.chris.g)
This should actually apply on all platforms without battery backends (Windows, Mac and Linux without DBus).
OS: Mac OS X → All
Hardware: x86_64 → All
Comment on attachment 578558 [details] [diff] [review]
Patch v1

Jonas, feel free to take this review from Chris. It's a two-line change (for real this time ;)) and Chris is on vacation AFAIK.
Attachment #578558 - Flags: review?(jonas)
Whiteboard: [needs review]
I marked this in-testsuite+ because technically the mochitests were throwing an assert but we don't fail on them yet.
Flags: in-testsuite+
Whiteboard: [needs review]
Target Milestone: --- → mozilla11
Attachment #578558 - Flags: review?(jones.chris.g) → checkin+
https://hg.mozilla.org/mozilla-central/rev/3d2eac7dcf66
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Depends on: 710178
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.