Closed Bug 707092 Opened 8 years ago Closed 8 years ago

Crash [@ GetTopLevelWindowActiveState] printing "-moz-appearance: -moz-window-frame-left"

Categories

(Core :: Widget: Win32, defect, critical)

x86_64
Windows 7
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: jruderman, Assigned: jimm)

References

(Blocks 1 open bug)

Details

(Keywords: crash, testcase)

Crash Data

Attachments

(3 files, 1 obsolete file)

Attached file testcase
1. Load the testcase
2. Print (to file)

Result: Crash [@ GetTopLevelWindowActiveState]
Attached file stack trace
There are a few crash reports per day with a matching signature. Most of the stacks are different or truncated, but they're crashing on the same source code line.
Attached patch add null check on window ptr (obsolete) — Splinter Review
I'll have to remember to use the test case of printing when working on this code. Thanks for reporting.
Assignee: nobody → jmathies
Attachment #578592 - Flags: review?(netzen)
Comment on attachment 578592 [details] [diff] [review]
add null check on window ptr

Review of attachment 578592 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/src/windows/nsNativeThemeWin.cpp
@@ +89,5 @@
>    // until it finds a real window.
>    nsIWidget* widget = aFrame->GetNearestWidget();
>    nsWindow * window = static_cast<nsWindow*>(widget);
> +  if (!window)
> +    return false;

nit: return 0;
Attachment #578592 - Flags: review?(netzen) → review+
much better.
Attachment #578592 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/e6d311cfc2e4
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.