Last Comment Bug 707092 - Crash [@ GetTopLevelWindowActiveState] printing "-moz-appearance: -moz-window-frame-left"
: Crash [@ GetTopLevelWindowActiveState] printing "-moz-appearance: -moz-window...
Status: RESOLVED FIXED
: crash, testcase
Product: Core
Classification: Components
Component: Widget: Win32 (show other bugs)
: Trunk
: x86_64 Windows 7
: -- critical (vote)
: mozilla11
Assigned To: Jim Mathies [:jimm]
:
:
Mentors:
Depends on:
Blocks: randomstyles
  Show dependency treegraph
 
Reported: 2011-12-02 00:37 PST by Jesse Ruderman
Modified: 2011-12-03 23:40 PST (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
testcase (77 bytes, text/html)
2011-12-02 00:37 PST, Jesse Ruderman
no flags Details
stack trace (14.83 KB, text/plain)
2011-12-02 00:37 PST, Jesse Ruderman
no flags Details
add null check on window ptr (854 bytes, patch)
2011-12-02 08:10 PST, Jim Mathies [:jimm]
netzen: review+
Details | Diff | Splinter Review
return proper constant (1.01 KB, patch)
2011-12-02 08:20 PST, Jim Mathies [:jimm]
no flags Details | Diff | Splinter Review

Description Jesse Ruderman 2011-12-02 00:37:03 PST
Created attachment 578513 [details]
testcase

1. Load the testcase
2. Print (to file)

Result: Crash [@ GetTopLevelWindowActiveState]
Comment 1 Jesse Ruderman 2011-12-02 00:37:30 PST
Created attachment 578514 [details]
stack trace
Comment 2 Jesse Ruderman 2011-12-02 00:39:16 PST
There are a few crash reports per day with a matching signature. Most of the stacks are different or truncated, but they're crashing on the same source code line.
Comment 3 Jim Mathies [:jimm] 2011-12-02 08:10:12 PST
Created attachment 578592 [details] [diff] [review]
add null check on window ptr

I'll have to remember to use the test case of printing when working on this code. Thanks for reporting.
Comment 4 Brian R. Bondy [:bbondy] 2011-12-02 08:14:34 PST
Comment on attachment 578592 [details] [diff] [review]
add null check on window ptr

Review of attachment 578592 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/src/windows/nsNativeThemeWin.cpp
@@ +89,5 @@
>    // until it finds a real window.
>    nsIWidget* widget = aFrame->GetNearestWidget();
>    nsWindow * window = static_cast<nsWindow*>(widget);
> +  if (!window)
> +    return false;

nit: return 0;
Comment 5 Jim Mathies [:jimm] 2011-12-02 08:20:04 PST
Created attachment 578594 [details] [diff] [review]
return proper constant

much better.
Comment 7 Marco Bonardo [::mak] 2011-12-03 03:15:08 PST
https://hg.mozilla.org/mozilla-central/rev/e6d311cfc2e4

Note You need to log in before you can comment on or make changes to this bug.