Crash [@ GetTopLevelWindowActiveState] printing "-moz-appearance: -moz-window-frame-left"

RESOLVED FIXED in mozilla11

Status

()

Core
Widget: Win32
--
critical
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jesse Ruderman, Assigned: jimm)

Tracking

(Blocks: 1 bug, {crash, testcase})

Trunk
mozilla11
x86_64
Windows 7
crash, testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(crash signature)

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Created attachment 578513 [details]
testcase

1. Load the testcase
2. Print (to file)

Result: Crash [@ GetTopLevelWindowActiveState]
(Reporter)

Comment 1

6 years ago
Created attachment 578514 [details]
stack trace
(Reporter)

Comment 2

6 years ago
There are a few crash reports per day with a matching signature. Most of the stacks are different or truncated, but they're crashing on the same source code line.
(Assignee)

Comment 3

6 years ago
Created attachment 578592 [details] [diff] [review]
add null check on window ptr

I'll have to remember to use the test case of printing when working on this code. Thanks for reporting.
Assignee: nobody → jmathies
Attachment #578592 - Flags: review?(netzen)
Comment on attachment 578592 [details] [diff] [review]
add null check on window ptr

Review of attachment 578592 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/src/windows/nsNativeThemeWin.cpp
@@ +89,5 @@
>    // until it finds a real window.
>    nsIWidget* widget = aFrame->GetNearestWidget();
>    nsWindow * window = static_cast<nsWindow*>(widget);
> +  if (!window)
> +    return false;

nit: return 0;
Attachment #578592 - Flags: review?(netzen) → review+
(Assignee)

Comment 5

6 years ago
Created attachment 578594 [details] [diff] [review]
return proper constant

much better.
Attachment #578592 - Attachment is obsolete: true
(Assignee)

Comment 6

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6d311cfc2e4
https://hg.mozilla.org/mozilla-central/rev/e6d311cfc2e4
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.