The default bug view has changed. See this FAQ.

msvc* dlls will never get removed on update

RESOLVED FIXED in Firefox 11

Status

()

Firefox
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Firefox 11
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 578538 [details] [diff] [review]
The fix

When we change the version of MSVC that we're using, we'll start shipping some new dlls, however we won't actually remove the old ones. This is because in removed-files.in they are listed as:

@BINPATH@/msvcm80.dll
@BINPATH@/msvcp80.dll
(etc)

However, the golden rule for moving/copying things from package-manifest.in is that you remove @BINPATH@.

Currently we're trying to remove bin/msvc* rather than just msvc* (I verified this looking at the make partial mar step in a nightly builds).
Attachment #578538 - Flags: review?(khuey)
Flags: in-testsuite-
Attachment #578538 - Flags: review?(khuey) → review+
(Assignee)

Comment 1

5 years ago
Landed on inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a8ff3d835ba
Whiteboard: [inbound]
Target Milestone: --- → Firefox 11
https://hg.mozilla.org/mozilla-central/rev/0a8ff3d835ba
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Blocks: 696422
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.