Closed Bug 707121 Opened 8 years ago Closed 8 years ago

msvc* dlls will never get removed on update

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla11

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Attached patch The fixSplinter Review
When we change the version of MSVC that we're using, we'll start shipping some new dlls, however we won't actually remove the old ones. This is because in removed-files.in they are listed as:

@BINPATH@/msvcm80.dll
@BINPATH@/msvcp80.dll
(etc)

However, the golden rule for moving/copying things from package-manifest.in is that you remove @BINPATH@.

Currently we're trying to remove bin/msvc* rather than just msvc* (I verified this looking at the make partial mar step in a nightly builds).
Attachment #578538 - Flags: review?(khuey)
Flags: in-testsuite-
Landed on inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a8ff3d835ba
Whiteboard: [inbound]
Target Milestone: --- → Firefox 11
https://hg.mozilla.org/mozilla-central/rev/0a8ff3d835ba
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 11 → mozilla11
You need to log in before you can comment on or make changes to this bug.