GCLI Completer could be simplified if repeated spans are not a performance issue

RESOLVED FIXED in Firefox 13

Status

()

Firefox
Developer Tools: Console
P4
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: jwalker, Assigned: jwalker)

Tracking

unspecified
Firefox 13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

See Completer.update() and particularly Completer.appendMarkupStatus()

<span>h</span>
<span>o</span>
<span>w</span>
<span> </span>
<span>m</span>
<span>u</span>
<span>c</span>
<span>h</span>
<span> </span>
<span>o</span>
<span>f</span>
<span> </span>
<span>a</span>
<span> </span>
<span>s</span>
<span>l</span>
<span>o</span>
<span>w</span>
<span> </span>
<span>d</span>
<span>o</span>
<span>w</span>
<span>n</span>
<span> </span>
<span>i</span>
<span>s</span>
<span> </span>
<span>t</span>
<span>h</span>
<span>i</span>
<span>s</span>

We're making the code more complex to avoid the situation above, but if there's no perceptable benefit, then simpler code could win out, especially if that meant we could use a template.
Triage. Filter on PEGASUS.
Priority: -- → P4
Triage. Filter on PEGASUS.
No longer blocks: 659052
win: glob the statuses together in inputStatusMarkup.
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Created attachment 593093 [details] [diff] [review]
upload 1

a.k.a https://github.com/campd/gcli/pull/20
Attachment #593093 - Flags: review?(dcamp)
https://tbpl.mozilla.org/?tree=Try&rev=b447debd6053
Target Milestone: --- → Firefox 13

Comment 6

5 years ago
Comment on attachment 593093 [details] [diff] [review]
upload 1

Does what it says on the label.  These completer dialogs are usually limited to a few lines anyway, right?
Attachment #593093 - Flags: review?(dcamp) → review+
(In reply to Dave Camp (:dcamp) from comment #6)
> Comment on attachment 593093 [details] [diff] [review]
> upload 1
> 
> Does what it says on the label.  These completer dialogs are usually limited
> to a few lines anyway, right?

Yes, and also the replacement code is template based without creating multiple spans - so no performance hit anyway.
https://tbpl.mozilla.org/?tree=Try&rev=946d867e53b4
Blocks: 724819
https://tbpl.mozilla.org/?tree=Fx-Team&rev=3e9fbc7eb447
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/3e9fbc7eb447
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
You need to log in before you can comment on or make changes to this bug.