Last Comment Bug 707131 - GCLI Completer could be simplified if repeated spans are not a performance issue
: GCLI Completer could be simplified if repeated spans are not a performance issue
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Console (show other bugs)
: unspecified
: All All
: P4 normal (vote)
: Firefox 13
Assigned To: Joe Walker [:jwalker] (needinfo me or ping on irc)
:
Mentors:
Depends on:
Blocks: 724819
  Show dependency treegraph
 
Reported: 2011-12-02 04:33 PST by Joe Walker [:jwalker] (needinfo me or ping on irc)
Modified: 2012-02-07 11:27 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
upload 1 (18.70 KB, patch)
2012-01-31 07:34 PST, Joe Walker [:jwalker] (needinfo me or ping on irc)
dcamp: review+
Details | Diff | Review

Description Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-12-02 04:33:55 PST
See Completer.update() and particularly Completer.appendMarkupStatus()

<span>h</span>
<span>o</span>
<span>w</span>
<span> </span>
<span>m</span>
<span>u</span>
<span>c</span>
<span>h</span>
<span> </span>
<span>o</span>
<span>f</span>
<span> </span>
<span>a</span>
<span> </span>
<span>s</span>
<span>l</span>
<span>o</span>
<span>w</span>
<span> </span>
<span>d</span>
<span>o</span>
<span>w</span>
<span>n</span>
<span> </span>
<span>i</span>
<span>s</span>
<span> </span>
<span>t</span>
<span>h</span>
<span>i</span>
<span>s</span>

We're making the code more complex to avoid the situation above, but if there's no perceptable benefit, then simpler code could win out, especially if that meant we could use a template.
Comment 1 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-13 09:39:07 PST
Triage. Filter on PEGASUS.
Comment 2 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-13 09:41:00 PST
Triage. Filter on PEGASUS.
Comment 3 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-31 01:50:43 PST
win: glob the statuses together in inputStatusMarkup.
Comment 4 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-31 07:34:13 PST
Created attachment 593093 [details] [diff] [review]
upload 1

a.k.a https://github.com/campd/gcli/pull/20
Comment 5 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-31 08:32:54 PST
https://tbpl.mozilla.org/?tree=Try&rev=b447debd6053
Comment 6 Dave Camp (:dcamp) 2012-02-02 17:50:59 PST
Comment on attachment 593093 [details] [diff] [review]
upload 1

Does what it says on the label.  These completer dialogs are usually limited to a few lines anyway, right?
Comment 7 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-02-03 00:19:46 PST
(In reply to Dave Camp (:dcamp) from comment #6)
> Comment on attachment 593093 [details] [diff] [review]
> upload 1
> 
> Does what it says on the label.  These completer dialogs are usually limited
> to a few lines anyway, right?

Yes, and also the replacement code is template based without creating multiple spans - so no performance hit anyway.
Comment 8 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-02-06 07:05:21 PST
https://tbpl.mozilla.org/?tree=Try&rev=946d867e53b4
Comment 9 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-02-07 03:36:11 PST
https://tbpl.mozilla.org/?tree=Fx-Team&rev=3e9fbc7eb447
Comment 10 Tim Taubert [:ttaubert] 2012-02-07 11:27:08 PST
https://hg.mozilla.org/mozilla-central/rev/3e9fbc7eb447

Note You need to log in before you can comment on or make changes to this bug.