707131 - GCLI Completer could be simplified if repeated spans are not a performance issue

Status: RESOLVED FIXED

(DevTools :: Console, defect, P4)

Description

[Joe Walker [:jwalker]]

See Completer.update() and particularly Completer.appendMarkupStatus()

<span>h</span>
<span>o</span>
<span>w</span>
<span> </span>
<span>m</span>
<span>u</span>
<span>c</span>
<span>h</span>
<span> </span>
<span>o</span>
<span>f</span>
<span> </span>
<span>a</span>
<span> </span>
<span>s</span>
<span>l</span>
<span>o</span>
<span>w</span>
<span> </span>
<span>d</span>
<span>o</span>
<span>w</span>
<span>n</span>
<span> </span>
<span>i</span>
<span>s</span>
<span> </span>
<span>t</span>
<span>h</span>
<span>i</span>
<span>s</span>

We're making the code more complex to avoid the situation above, but if there's no perceptable benefit, then simpler code could win out, especially if that meant we could use a template.

Comment 1

[Joe Walker [:jwalker]]

Triage. Filter on PEGASUS.

Comment 2

[Joe Walker [:jwalker]]

Triage. Filter on PEGASUS.

Comment 3

[Joe Walker [:jwalker]]

win: glob the statuses together in inputStatusMarkup.

Comment 4

[Joe Walker [:jwalker]]

Attachment: upload 1

a.k.a https://github.com/campd/gcli/pull/20

Comment 5

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Try&rev=b447debd6053

Comment 6

[Dave Camp (:dcamp)]

Comment on attachment 593093 [details] [diff] [review]
upload 1

Does what it says on the label.  These completer dialogs are usually limited to a few lines anyway, right?

Comment 7

[Joe Walker [:jwalker]]

(In reply to Dave Camp (:dcamp) from comment #6)
> Comment on attachment 593093 [details] [diff] [review]
> upload 1
> 
> Does what it says on the label.  These completer dialogs are usually limited
> to a few lines anyway, right?

Yes, and also the replacement code is template based without creating multiple spans - so no performance hit anyway.

Comment 8

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Try&rev=946d867e53b4

Comment 9

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Fx-Team&rev=3e9fbc7eb447

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/3e9fbc7eb447