Closed Bug 707180 Opened 8 years ago Closed 8 years ago

JavaScript strict warning: 'Reference to undefined property aBrowser.__SS_restoreState'

Categories

(Firefox :: Session Restore, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Firefox 11

People

(Reporter: Tobbi, Assigned: Tobbi)

Details

Attachments

(1 file)

Attached patch patch v1Splinter Review
This fixes a warning I got in the console for undefined property aBrowser.__SS_restoreState
Comment on attachment 578591 [details] [diff] [review]
patch v1

Thanks. I'd seen that a few times but hadn't looked into it yet.
Attachment #578591 - Attachment is patch: true
Attachment #578591 - Flags: review+
https://hg.mozilla.org/integration/fx-team/rev/018d5cc8236e
Summary: [patch] JavaScript strict warning: 'Reference to undefined property aBrowser.__SS_restoreState' → JavaScript strict warning: 'Reference to undefined property aBrowser.__SS_restoreState'
Whiteboard: [fixed-in-fx-team]
Assignee: nobody → tobbi.bugs
https://hg.mozilla.org/mozilla-central/rev/018d5cc8236e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 11
Comment on attachment 578591 [details] [diff] [review]
patch v1

Review of attachment 578591 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/sessionstore/src/nsSessionStore.js
@@ +4525,4 @@
>    onStateChange: function (aBrowser, aWebProgress, aRequest, aStateFlags, aStatus) {
>      // Ignore state changes on browsers that we've already restored and state
>      // changes that aren't applicable.
> +    if (aBrowser.__SS_restoreState &&

Does this really work? I thought it would be ("__SS_restoreState" in aBrowser).
You need to log in before you can comment on or make changes to this bug.