Last Comment Bug 707180 - JavaScript strict warning: 'Reference to undefined property aBrowser.__SS_restoreState'
: JavaScript strict warning: 'Reference to undefined property aBrowser.__SS_res...
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Session Restore (show other bugs)
: unspecified
: All All
: -- trivial (vote)
: Firefox 11
Assigned To: [retired]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-02 08:07 PST by [retired]
Modified: 2012-12-18 04:50 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch v1 (1.04 KB, patch)
2011-12-02 08:07 PST, [retired]
paul: review+
Details | Diff | Splinter Review

Description [retired] 2011-12-02 08:07:55 PST
Created attachment 578591 [details] [diff] [review]
patch v1

This fixes a warning I got in the console for undefined property aBrowser.__SS_restoreState
Comment 1 Paul O'Shannessy [:zpao] (not reading much bugmail, email directly) 2011-12-02 10:06:40 PST
Comment on attachment 578591 [details] [diff] [review]
patch v1

Thanks. I'd seen that a few times but hadn't looked into it yet.
Comment 2 Paul O'Shannessy [:zpao] (not reading much bugmail, email directly) 2011-12-02 10:23:01 PST
https://hg.mozilla.org/integration/fx-team/rev/018d5cc8236e
Comment 3 Tim Taubert [:ttaubert] 2011-12-06 00:02:30 PST
https://hg.mozilla.org/mozilla-central/rev/018d5cc8236e
Comment 4 ithinc 2012-12-18 04:50:00 PST
Comment on attachment 578591 [details] [diff] [review]
patch v1

Review of attachment 578591 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/sessionstore/src/nsSessionStore.js
@@ +4525,4 @@
>    onStateChange: function (aBrowser, aWebProgress, aRequest, aStateFlags, aStatus) {
>      // Ignore state changes on browsers that we've already restored and state
>      // changes that aren't applicable.
> +    if (aBrowser.__SS_restoreState &&

Does this really work? I thought it would be ("__SS_restoreState" in aBrowser).

Note You need to log in before you can comment on or make changes to this bug.