JavaScript strict warning: 'Reference to undefined property aBrowser.__SS_restoreState'

RESOLVED FIXED in Firefox 11

Status

()

Firefox
Session Restore
--
trivial
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Tobbi, Assigned: Tobbi)

Tracking

unspecified
Firefox 11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 578591 [details] [diff] [review]
patch v1

This fixes a warning I got in the console for undefined property aBrowser.__SS_restoreState
Comment on attachment 578591 [details] [diff] [review]
patch v1

Thanks. I'd seen that a few times but hadn't looked into it yet.
Attachment #578591 - Attachment is patch: true
Attachment #578591 - Flags: review+
https://hg.mozilla.org/integration/fx-team/rev/018d5cc8236e
Summary: [patch] JavaScript strict warning: 'Reference to undefined property aBrowser.__SS_restoreState' → JavaScript strict warning: 'Reference to undefined property aBrowser.__SS_restoreState'
Whiteboard: [fixed-in-fx-team]
(Assignee)

Updated

6 years ago
Assignee: nobody → tobbi.bugs
https://hg.mozilla.org/mozilla-central/rev/018d5cc8236e
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 11

Comment 4

5 years ago
Comment on attachment 578591 [details] [diff] [review]
patch v1

Review of attachment 578591 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/sessionstore/src/nsSessionStore.js
@@ +4525,4 @@
>    onStateChange: function (aBrowser, aWebProgress, aRequest, aStateFlags, aStatus) {
>      // Ignore state changes on browsers that we've already restored and state
>      // changes that aren't applicable.
> +    if (aBrowser.__SS_restoreState &&

Does this really work? I thought it would be ("__SS_restoreState" in aBrowser).
You need to log in before you can comment on or make changes to this bug.