707221 - Soup: 500 Error when trying to log in via BrowserID to Apps Dev preview page

Status: VERIFIED FIXED

(Web Apps :: Soup, defect, P1)

Description

[Tony Chung [:tchung]]

Attachment: Logcat error 500

on Soup, I'm having trouble connecting to apps-preview-dev.allizom.org through BrowserID.  

Error being returned says 500 error.

attaching logcat and screenshot.   Notice the screenshot or login error is not helpful to the user (assertion)

Repro:
1) Android 2.3.4, Samsung galaxy S 2
2) install 12-01-2011 soup build from http://people.mozilla.com/~dclarke/openwebapps/Soup/latest/Soup.apk
3) point Soup store settings to the following:
* Store provider: apps-preview-dev.allizom.org
* Identity provider: browserid.org
4) launch app, and click on Log in with browserID
5) Verify login errors

12-02 10:20:28.985: DEBUG/MozIdPlugin(6599): Called postVerify: ["https:\/\/apps-preview-dev.allizom.org",null]
12-02 10:20:28.985: DEBUG/SoupClient(6599): verifyId for https://apps-preview-dev.allizom.org from https://browserid.org/verify: null
12-02 10:20:28.990: WARN/SingleClientConnManager(6599): Invalid use of SingleClientConnManager: connection still allocated.
12-02 10:20:28.990: WARN/SingleClientConnManager(6599): Make sure to release the connection before allocating another one.
12-02 10:20:29.130: DEBUG/dalvikvm(6599): GC_CONCURRENT freed 857K, 54% free 3651K/7879K, external 1440K/1493K, paused 1ms+3ms
12-02 10:20:29.175: WARN/SoupClient(6599): verifyId failed
12-02 10:20:29.175: WARN/SoupClient(6599): java.lang.Exception: Unexpected server response HTTP/1.1 500 Internal Server Error for POST https://browserid.org/verify HTTP/1.1
12-02 10:20:29.175: WARN/SoupClient(6599):     at org.mozilla.labs.Soup.service.SoupClient.execute(SoupClient.java:139)
12-02 10:20:29.175: WARN/SoupClient(6599):     at org.mozilla.labs.Soup.service.SoupClient.executePost(SoupClient.java:98)
12-02 10:20:29.175: WARN/SoupClient(6599):     at org.mozilla.labs.Soup.service.SoupClient.verifyId(SoupClient.java:370)
12-02 10:20:29.175: WARN/SoupClient(6599):     at org.mozilla.labs.Soup.plugins.MozIdPlugin.postVerify(MozIdPlugin.java:129)
12-02 10:20:29.175: WARN/SoupClient(6599):     at org.mozilla.labs.Soup.plugins.MozIdPlugin.execute(MozIdPlugin.java:48)
12-02 10:20:29.175: WARN/SoupClient(6599):     at com.phonegap.api.PluginManager$1.run(PluginManager.java:145)
12-02 10:20:29.175: WARN/SoupClient(6599):     at java.lang.Thread.run(Thread.java:1019)
12-02 10:20:29.175: DEBUG/MozIdPlugin(6599): postVerify returned null for https://apps-preview-dev.allizom.org

Expected:
- login successful

Actual;
- login errors

Comment 1

[Tony Chung [:tchung]]

Attachment: login error screenshot

unhelpful error screenshot, not describing to the user what went wrong with sign in.

Comment 2

[:Harald Kirschner :digitarald]

Added Toast message when login fails. Also the login doesn't send empty assertions anymore.

Comment 3

[Aaron Train [:aaronmt]]

Verified Fixed
--
Samsung Nexus S (Android 2.3.6)
origin/HEAD 7743233319