backgroundUpdateCheck isn't firing its complete notification correctly

RESOLVED FIXED in Firefox 10

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

Trunk
mozilla11
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +
in-litmus -

Firefox Tracking Flags

(firefox10 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Found a couple of bugs introduced in bug 527141 and bug 693906, one causes the notification to fire too early another causes it to not fire at all when there are no XPI add-ons present.
(Assignee)

Comment 1

6 years ago
Created attachment 578729 [details] [diff] [review]
patch rev 1

Patch and automated test
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Attachment #578729 - Flags: review?(bmcbride)
Comment on attachment 578729 [details] [diff] [review]
patch rev 1

Review of attachment 578729 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for catching that.
Attachment #578729 - Flags: review?(bmcbride) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/99e27f500ad3
https://hg.mozilla.org/mozilla-central/rev/99e27f500ad3
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Comment on attachment 578729 [details] [diff] [review]
patch rev 1

This fixes an issue in the patches from bug 527141 and bug 693906, so if they go on Aurora, this needs to too.
Attachment #578729 - Flags: approval-mozilla-aurora?

Comment 6

6 years ago
Comment on attachment 578729 [details] [diff] [review]
patch rev 1

[Triage Comment]
We're told that this is sufficiently low risk and should button up the feature. Approving for Aurora.
Attachment #578729 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/b15fd1a50810
status-firefox10: --- → fixed
Is this something QA can verify?
Whiteboard: [qa?]
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #8)
> Is this something QA can verify?

Not really, no. But it's covered well enough by an xpcshell test.
Flags: in-testsuite+
Flags: in-litmus-
Whiteboard: [qa?] → [qa-]
You need to log in before you can comment on or make changes to this bug.