The default bug view has changed. See this FAQ.

Remove VOUCH_DOES_NOT_REQUIRE_STACK_FRAME

RESOLVED FIXED in mozilla11

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dmandelin, Assigned: dmandelin)

Tracking

Trunk
mozilla11
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 578748 [details] [diff] [review]
Patch

Required only for the tracer.
Attachment #578748 - Flags: review?(jorendorff)
(Assignee)

Updated

5 years ago
Assignee: general → dmandelin
Comment on attachment 578748 [details] [diff] [review]
Patch

I guess this changes behavior in js_FindClassObject in the goofball case where the JS stack is empty and cx->globalObject is null. We used to set *vp to undefined and return true. Now we will throw.

Fine with me, if it passes try server.

Thanks for doing this.
Attachment #578748 - Flags: review?(jorendorff) → review+
(Assignee)

Comment 2

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/e67dd183cd4d

There were a few failures on try, but they seemed to be failures that lots of other try builds were having, so I think it's good.
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/e67dd183cd4d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.