Last Comment Bug 707341 - Remove VOUCH_DOES_NOT_REQUIRE_STACK_FRAME
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: x86_64 Windows 7
-- normal (vote)
: mozilla11
Assigned To: David Mandelin [:dmandelin]
: Jason Orendorff [:jorendorff]
Depends on:
Blocks: 698201
  Show dependency treegraph
Reported: 2011-12-02 15:21 PST by David Mandelin [:dmandelin]
Modified: 2011-12-09 06:56 PST (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (9.98 KB, patch)
2011-12-02 15:21 PST, David Mandelin [:dmandelin]
jorendorff: review+
Details | Diff | Splinter Review

Description User image David Mandelin [:dmandelin] 2011-12-02 15:21:05 PST
Created attachment 578748 [details] [diff] [review]

Required only for the tracer.
Comment 1 User image Jason Orendorff [:jorendorff] 2011-12-06 15:57:37 PST
Comment on attachment 578748 [details] [diff] [review]

I guess this changes behavior in js_FindClassObject in the goofball case where the JS stack is empty and cx->globalObject is null. We used to set *vp to undefined and return true. Now we will throw.

Fine with me, if it passes try server.

Thanks for doing this.
Comment 2 User image David Mandelin [:dmandelin] 2011-12-08 11:56:32 PST

There were a few failures on try, but they seemed to be failures that lots of other try builds were having, so I think it's good.
Comment 3 User image Ed Morley [:emorley] 2011-12-09 06:56:30 PST

Note You need to log in before you can comment on or make changes to this bug.