Closed Bug 707341 Opened 13 years ago Closed 13 years ago

Remove VOUCH_DOES_NOT_REQUIRE_STACK_FRAME

Categories

(Core :: JavaScript Engine, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: dmandelin, Assigned: dmandelin)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Required only for the tracer.
Attachment #578748 - Flags: review?(jorendorff)
Assignee: general → dmandelin
Comment on attachment 578748 [details] [diff] [review]
Patch

I guess this changes behavior in js_FindClassObject in the goofball case where the JS stack is empty and cx->globalObject is null. We used to set *vp to undefined and return true. Now we will throw.

Fine with me, if it passes try server.

Thanks for doing this.
Attachment #578748 - Flags: review?(jorendorff) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/e67dd183cd4d

There were a few failures on try, but they seemed to be failures that lots of other try builds were having, so I think it's good.
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/e67dd183cd4d
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: