Last Comment Bug 707351 - Remove tracer-specific stuff from jit-tests
: Remove tracer-specific stuff from jit-tests
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: mozilla11
Assigned To: David Mandelin [:dmandelin]
:
Mentors:
Depends on:
Blocks: 698201
  Show dependency treegraph
 
Reported: 2011-12-02 15:45 PST by David Mandelin [:dmandelin]
Modified: 2012-02-01 13:58 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
WIP (54.71 KB, patch)
2011-12-02 15:45 PST, David Mandelin [:dmandelin]
no flags Details | Diff | Review
Patch (111.28 KB, patch)
2011-12-05 13:41 PST, David Mandelin [:dmandelin]
dvander: review+
Details | Diff | Review

Description David Mandelin [:dmandelin] 2011-12-02 15:45:57 PST
Created attachment 578758 [details] [diff] [review]
WIP

There is TMFLAGS support in the harness, and checkStats in the test cases.

Posting a WIP that removes those things but isn't done. I removed HOTLOOP and RUNLOOP too, but there are lots of tests that use those, so we need to put them back, modify the tests, or delete the tests.

I removed some tests that only checked checkStats stuff, or were otherwise totally tracer-specific. I suspect that many of the other tests that used to call checkStats, and some other tests, are pretty much specific to the tracer and are unlikely to catch many bugs now.
Comment 1 David Mandelin [:dmandelin] 2011-12-05 13:41:56 PST
Created attachment 579149 [details] [diff] [review]
Patch
Comment 2 David Mandelin [:dmandelin] 2011-12-06 11:29:42 PST
http://hg.mozilla.org/integration/mozilla-inbound/rev/39b7b2f8e840
Comment 3 Ed Morley [:emorley] 2011-12-07 02:47:22 PST
https://hg.mozilla.org/mozilla-central/rev/39b7b2f8e840

Note You need to log in before you can comment on or make changes to this bug.