Last Comment Bug 707352 - Remove NS_FINAL_CLASS
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: unspecified
: All All
-- minor (vote)
: mozilla11
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
: Nathan Froyd [:froydnj][high latency until 6 March]
Depends on:
  Show dependency treegraph
Reported: 2011-12-02 15:49 PST by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2011-12-07 12:28 PST (History)
7 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (4.61 KB, patch)
2011-12-02 15:49 PST, Jeff Walden [:Waldo] (remove +bmo to email)
cjones.bugs: review+
Details | Diff | Splinter Review

Description User image Jeff Walden [:Waldo] (remove +bmo to email) 2011-12-02 15:49:08 PST
Created attachment 578759 [details] [diff] [review]

It's had its day, and C++11 magic now supersedes it.  Let's kill it.  I think this patch will do the trick, although I base that belief mostly on MXR-searching and the like.

The Clang developers are of the opinion that it should be an error for an abstract class to be final, so nsDerivedSafe will not be marked with MOZ_FINAL.
Comment 1 User image Jeff Walden [:Waldo] (remove +bmo to email) 2011-12-07 08:58:51 PST
Comment 2 User image Matt Brubeck (:mbrubeck) 2011-12-07 12:28:36 PST

Note You need to log in before you can comment on or make changes to this bug.