70740 - case-insensitive string comparison for nsAReadableString

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It would be nice to have some way to do case-insensitive string comparison on an
nsAReadableString.  Right now, AFAICT, the only ways to do it are through nsCRT
(on char* or PRUnichar*) or through nsString::EqualsIgnoreCase.  This means that
if one wants to do a case-insensitive comparison of a substring of one
nsAReadableString to all of another, one must copy the substring.  A good
example of where this would be useful is bug 70734.

Comment 1

[Scott Collins]

*** Bug 48853 has been marked as a duplicate of this bug. ***

Comment 2

[Scott Collins]

Attachment: case insensitive comparison

Comment 3

[Simon Fraser [no longer active]]

sr=sfraser

Comment 4

[mjudge]

r=mjudge

Comment 5

[Scott Collins]

fix checked in

Comment 6

[Daniel Bratell]

This was only for the ASCII subset of Unicode I guess?

Comment 7

[Scott Collins]

The fix I checked in allowed clients to specify a comparator, a la

  Compare(a, b, nsCaseInsensitiveStringComparator())

The specific comparator I mention above uses |nsCRT::strncasecmp| to compare
actual hunks, but you can supply your own if you have a more specific desire.
|strncasecmp| is the existing behavior for case insensitive comparisons (i.e.,
what |nsString| supplied before).  It's original rickg code.  It _looks_ to me
like it only works in the iso latin 1 subset (at least that's what the naming
leads me to believe); but you are free to provide your own comparator if this
isn't sufficient.