707423 - IonMonkey: compile global scripts

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

We need this for bitwise-and.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: WIP v0, runs bitwise-and

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: WIP v1, handles bailouts

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: patch

passes tests

Comment 4

[Chris Leary [:cdleary] (not checking bugmail)]

Comment on attachment 587585 [details] [diff] [review]
patch

Review of attachment 587585 [details] [diff] [review]:
-----------------------------------------------------------------

Just a few nits. Looks good!

::: js/src/ion/Bailouts.cpp
@@ +259,5 @@
>          return BAILOUT_RETURN_FATAL_ERROR;
>      activation->setBailout(br);
>  
>      // Non-function frames are not supported yet. We don't compile or enter
>      // global scripts so this assert should not fire yet.

Nit: can remove this comment, because we do!

::: js/src/ion/CompileInfo.h
@@ +46,5 @@
>  
>  inline uintN
>  CountArgSlots(JSFunction *fun)
>  {
> +    return fun ? fun->nargs + 2 : 1; // +2 for |scopeChain| and |this|, or +1 for |this|

As discussed on IRC, I think the global object gets +1 for |scopeChain| instead of |this|

::: js/src/ion/IonBuilder.cpp
@@ +2444,5 @@
>          osrBlock->add(scopev);
>          osrBlock->initSlot(slot, scopev);
>      }
>  
>      // Initialize |this| parameter.

Nit: can we push this comment down into the block?

::: js/src/jit-test/tests/v8-v5/check-splay.js
@@ +91,5 @@
>    } while (splayTree.find(key) != null);
>    splayTree.insert(key, GeneratePayloadTree(kSplayTreePayloadDepth, key));
>    return key;
>  }
> +dis(InsertNewNode);

Nit: not sure if it's bad to leave this in.

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

http://hg.mozilla.org/projects/ionmonkey/rev/f3fef5d48874