Closed
Bug 707423
Opened 13 years ago
Closed 12 years ago
IonMonkey: compile global scripts
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: jandem, Assigned: dvander)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
21.69 KB,
patch
|
cdleary
:
review+
|
Details | Diff | Splinter Review |
We need this for bitwise-and.
Reporter | ||
Updated•12 years ago
|
Assignee: general → dvander
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #587571 -
Attachment is obsolete: true
Assignee | ||
Comment 3•12 years ago
|
||
passes tests
Attachment #587581 -
Attachment is obsolete: true
Attachment #587585 -
Flags: review?
Assignee | ||
Updated•12 years ago
|
Attachment #587585 -
Flags: review? → review?(christopher.leary)
Comment 4•12 years ago
|
||
Comment on attachment 587585 [details] [diff] [review] patch Review of attachment 587585 [details] [diff] [review]: ----------------------------------------------------------------- Just a few nits. Looks good! ::: js/src/ion/Bailouts.cpp @@ +259,5 @@ > return BAILOUT_RETURN_FATAL_ERROR; > activation->setBailout(br); > > // Non-function frames are not supported yet. We don't compile or enter > // global scripts so this assert should not fire yet. Nit: can remove this comment, because we do! ::: js/src/ion/CompileInfo.h @@ +46,5 @@ > > inline uintN > CountArgSlots(JSFunction *fun) > { > + return fun ? fun->nargs + 2 : 1; // +2 for |scopeChain| and |this|, or +1 for |this| As discussed on IRC, I think the global object gets +1 for |scopeChain| instead of |this| ::: js/src/ion/IonBuilder.cpp @@ +2444,5 @@ > osrBlock->add(scopev); > osrBlock->initSlot(slot, scopev); > } > > // Initialize |this| parameter. Nit: can we push this comment down into the block? ::: js/src/jit-test/tests/v8-v5/check-splay.js @@ +91,5 @@ > } while (splayTree.find(key) != null); > splayTree.insert(key, GeneratePayloadTree(kSplayTreePayloadDepth, key)); > return key; > } > +dis(InsertNewNode); Nit: not sure if it's bad to leave this in.
Attachment #587585 -
Flags: review?(christopher.leary) → review+
Assignee | ||
Comment 5•12 years ago
|
||
http://hg.mozilla.org/projects/ionmonkey/rev/f3fef5d48874
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•