The default bug view has changed. See this FAQ.

Cleanup nsHTMLFormElement::DoSubmitOrReset a bit

RESOLVED FIXED in mozilla11

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla11
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 578845 [details] [diff] [review]
Patch v1

The assigning to rv is kind of silly.
Attachment #578845 - Flags: review?(mounir)
Flags: in-testsuite-
Comment on attachment 578845 [details] [diff] [review]
Patch v1

Review of attachment 578845 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks :)

::: content/html/content/src/nsHTMLFormElement.cpp
@@ +691,2 @@
>    }
> +  return NS_OK;

nit: you could add a warning/error/assertion if we get there: we should only get NS_FORM_RESET and NS_FORM_SUBMIT messages.

@@ +696,5 @@
>  nsHTMLFormElement::DoReset()
>  {
>    // JBK walk the elements[] array instead of form frame controls - bug 34297
>    PRUint32 numElements = GetElementCount();
> +  for (PRUint32 elementX = 0; elementX < numElements; elementX++) {

nit: while changing this line, change |elementX++| to |++elementX|.
Attachment #578845 - Flags: review?(mounir) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/mozilla-central/rev/fa6dc855be00
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.