Closed
Bug 707448
Opened 13 years ago
Closed 13 years ago
Cleanup nsHTMLFormElement::DoSubmitOrReset a bit
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
1.40 KB,
patch
|
mounir
:
review+
|
Details | Diff | Splinter Review |
The assigning to rv is kind of silly.
Attachment #578845 -
Flags: review?(mounir)
Flags: in-testsuite-
|
||
Comment 1•13 years ago
|
||
Comment on attachment 578845 [details] [diff] [review]
Patch v1
Review of attachment 578845 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks :)
::: content/html/content/src/nsHTMLFormElement.cpp
@@ +691,2 @@
> }
> + return NS_OK;
nit: you could add a warning/error/assertion if we get there: we should only get NS_FORM_RESET and NS_FORM_SUBMIT messages.
@@ +696,5 @@
> nsHTMLFormElement::DoReset()
> {
> // JBK walk the elements[] array instead of form frame controls - bug 34297
> PRUint32 numElements = GetElementCount();
> + for (PRUint32 elementX = 0; elementX < numElements; elementX++) {
nit: while changing this line, change |elementX++| to |++elementX|.
Attachment #578845 -
Flags: review?(mounir) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: --- → mozilla11
You need to log in
before you can comment on or make changes to this bug.
Description
•