Closed Bug 70745 Opened 24 years ago Closed 23 years ago

[XUL Syntax] Convert <text> and <html> to <description> or <label>

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Platform:
x86
Other
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.5

People

(Reporter: hyatt, Assigned: hyatt)

References

Details

(Whiteboard: [xul1.0-widgets-label])

Attachments

(1 file)

The xbl binding for label doesn't include the for handler from text-label.
692 bytes, patch
Details | Diff | Splinter Review 
All uses of <text> and <html> in dialogs to represent labels should be converted
to a new tag called <label>.

<label> itself should extend a new tag called <block> that represents only text.

The crop attribute on <block> or <label> determines whether or not you get
wrapping text (a real block that supports full markup) or the XUL text frame (a
single-line, no markup, no wrapping, cropping text).

When this bug is fixed, all occurrences of <text> and <html> should be
eliminated from XUL.
Status: NEW → ASSIGNED
Whiteboard: [XUL1.0]
Depends on: 70753
No longer depends on: 70753
Blocks: 70753
Keywords: helpwanted
Target Milestone: --- → mozilla1.0
mass-targetting to mozilla1.0, adding helpwanted keyword
Is this going to be
 
  <label value="name" />

or
  
  <label>name</label>

and why?
Both will work and be equivalent (except that with the latter, you'll be able to
put arbitrary markup into your label).


Ben, I'm wondering now about <block>.  The assertion was that you'd use that
inside your XBL, but now I'm wondering if <block> and <label> shouldn't be
collapsed back into the same tag.

Here's why.  We're making a conversion so that buttons say...

<button label="Foo"/>

It should also be possible to say

<button>
  <label>Foo</label>
</button>

This means the internal XBL is going to end up using <label>, not <block>.

The same argument applies to <menu>.  I should be able to say...

<menu>
  <label>Foo</label>
</menu>

I guess we could still use <block> for any of the non-primary labels in XBL...
e.g., for the acceltext of a menu.

is <label label="my label"> also going to work?
No.  Label and block will take value attributes.

The idea is that label="..." will always be a syntactic shorthand for the use of
<label value="..."/>.  It means that somewhere inside your XBL for the widget,
an anonymous <label> tag is being used.

Thinking of taking this when the other changes go in.  Hyatt, did you ever talk 
with Ben and decide about <block> (per your 3/9 comment)?
For what it's worth, I'd like to see them collapsed into the same tag as well 
(shorthand, cropping, non-wrapping <label value="..."/> and block, non-
cropping, non-wrapping <label>...</label).  This would be in keeping with one 
of the goals of these syntax changes (per Ben) -- simplification.
Quick (I hope) question.

Does the conversion of <text> and <html> to <label> applies to XUL only, not XBL?

If so, this would fix something that I found quite annoying - since XUL used
<html> in dialogs you had to add a margin to it only to have to remove the
margin in any widgets in which you wanted to use anonymous <html> :-(
Hmm... that doesn't work unless you make the label extends="xul:button"
Is this checked in?  In my button code, I still need to use <button value=""> as
opposed to <button label=""> which I think should work...
This isn't going to happen.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → WONTFIX
I expect this to be full of grief, but...
how about a reasoning?
Is it just time, or is there more to it?

Axel
why not?
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
what is going on with this bug?
Back with a vengeance.  We have a plan.
Status: REOPENED → ASSIGNED
Keywords: helpwanted
Summary: [XUL Syntax] Convert <text> and <html> to <block> and <label> → [XUL Syntax] Convert <text> and <html> to <label>
Whiteboard: [XUL1.0] → [xul1.0-widgets-label]
Target Milestone: mozilla1.0 → mozilla0.9.5
Depends on: 93626
Summary: [XUL Syntax] Convert <text> and <html> to <label> → [XUL Syntax] Convert <text> and <html> to <description> or <label>
THe new tags are fully implemented.  I'm not going to force anyone to do the 
conversion, since that would be a nightmare.  I'm just going to close this out 
as done.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Si.
Status: RESOLVED → VERIFIED
Will this mean that checkboxes can have their accesskeys underlined?
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: