Use a template to get the array length for nsGenericElement::FindAttributeDependence

RESOLVED FIXED in mozilla11

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 578896 [details] [diff] [review]
Patch v1

As described at <https://whereswalden.com/2011/10/20/implementing-mozillaarraylength-and-mozillaarrayend-and-some-followup-work/>.
Attachment #578896 - Flags: review?(jwalden+bmo)
Comment on attachment 578896 [details] [diff] [review]
Patch v1

Review of attachment 578896 [details] [diff] [review]:
-----------------------------------------------------------------

Looks nice.  Is this every caller of FindAttributeDependence?  If it is, please mark the original FindAttributeDependence function private within nsGenericElement.  If it isn't, we should consider whether the other callers could be changed somehow.  I'll ping you on IRC tomorrow and we can figure out something here, if something need be figured out.
Attachment #578896 - Flags: review?(jwalden+bmo) → review+
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/mozilla-central/rev/c74e2c35fd96
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.