Last Comment Bug 707498 - Use a template to get the array length for nsGenericElement::FindAttributeDependence
: Use a template to get the array length for nsGenericElement::FindAttributeDep...
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla11
Assigned To: :Ms2ger (⌚ UTC+1/+2)
: Andrew Overholt [:overholt]
Depends on:
Blocks: 696242
  Show dependency treegraph
Reported: 2011-12-04 04:41 PST by :Ms2ger (⌚ UTC+1/+2)
Modified: 2011-12-18 07:13 PST (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch v1 (41.25 KB, patch)
2011-12-04 04:41 PST, :Ms2ger (⌚ UTC+1/+2)
jwalden+bmo: review+
Details | Diff | Splinter Review

Comment 1 User image Jeff Walden [:Waldo] (remove +bmo to email) 2011-12-06 19:59:15 PST
Comment on attachment 578896 [details] [diff] [review]
Patch v1

Review of attachment 578896 [details] [diff] [review]:

Looks nice.  Is this every caller of FindAttributeDependence?  If it is, please mark the original FindAttributeDependence function private within nsGenericElement.  If it isn't, we should consider whether the other callers could be changed somehow.  I'll ping you on IRC tomorrow and we can figure out something here, if something need be figured out.
Comment 2 User image :Ms2ger (⌚ UTC+1/+2) 2011-12-18 07:13:25 PST

Note You need to log in before you can comment on or make changes to this bug.