707567 - prepend http:// to URL copy selection only if (at least) full hostname is selected

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Waldir Pimenta]

This issue was raised in comments to other bugs:
- bug 666964, comment 13
- bug 689342, comment 8
But neither bug tackled this issue directly, so those comments kinda drowned in the discussion surrounding the somewhat controversial hiding of the http:// from the location bar.

Thus I'm opening a bug specifically for this effect, since bug 666964, which got implemented, mentions adding the http:// "if the first character is included in the selection", and it seems straightforward to extend this to a slightly more rigid condition (and a more logical one): to add the http:// only if at least the full hostname is selected.

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

hopefully with proper English this time

Comment 3

[Dietrich Ayala (:dietrich)]

Comment on attachment 582720 [details] [diff] [review]
patch

Review of attachment 582720 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/browser_urlbarCopying.js
@@ +65,1 @@
>    },

worth adding a test for "<example>.com/foo"? or is that case covered elsewhere?

::: browser/base/content/urlbarBindings.xml
@@ +519,5 @@
> +          if (selectedVal.indexOf("/") == -1) {
> +            let remainder = inputVal.replace(selectedVal, "");
> +            if (remainder != "" && remainder[0] != "/")
> +              return selectedVal;
> +          }

please add a comment summarizing the criteria for determining whether the full domain has been selected or not.

Comment 4

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d3dbf8ffab2

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6d3dbf8ffab2

Comment 6

[Waldir Pimenta]

Thanks guys, you are awesome :D