Package.pm shouldn't copy older files

RESOLVED FIXED in mozilla15

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 578947 [details] [diff] [review]
Patch v1

Packager.pm is currently copying all files regardless of the last modification time. It's currently not changing anything because destination files are removed before copying. However, with bug 707569, we might end up not removing those files (maybe only if a certain env variable is set).
Attachment #578947 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #578947 - Flags: review? → review?(robert.bugzilla)
(Assignee)

Comment 1

5 years ago
By any chance Kyle, do you think you could take this review?
Component: NSIS Installer → Build Config
Product: Toolkit → Core
QA Contact: nsis.installer → build-config
Comment on attachment 578947 [details] [diff] [review]
Patch v1

Though this code is under installer it is actually packaging code and should be reviewed by Kyle or Ted. I'm ok with the patch but it would be best to have Kyle review it.
Attachment #578947 - Flags: review?(robert.bugzilla)
Attachment #578947 - Flags: review?(khuey)
Attachment #578947 - Flags: review+
Attachment #578947 - Flags: review?(khuey) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/2b35bacd2193
https://hg.mozilla.org/mozilla-central/rev/2b35bacd2193
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.