Closed
Bug 70760
Opened 24 years ago
Closed 24 years ago
run-mozilla.sh has hardcoded reference to mozilla-bin
Categories
(Core :: DOM: Navigation, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mcafee, Assigned: adamlock)
Details
Attachments
(2 files)
1.03 KB,
patch
|
Details | Diff | Splinter Review | |
1.92 KB,
patch
|
jud
:
review+
|
Details | Diff | Splinter Review |
gtkEmbed should be a script that strats gtkEmbed-bin,
in the same way that mozilla starts mozilla-bin.
Comment 2•24 years ago
|
||
Good idea, this will help solve the problem of switching to the new allocator
under Linux as well.
Status: NEW → ASSIGNED
OS: Windows 2000 → Linux
Target Milestone: --- → mozilla0.9
Reporter | ||
Comment 3•24 years ago
|
||
right. Add new stuff to the script, everyone kinda gets
the new stuff for free. just remember to type "gtkEmbed",
easy & simple.
Instead of two scripts, can't you modify the existing mozilla script so that
it's name determines which binary it launches?
e.g.
Call the script "mozilla" and it launches "mozilla-bin"
Call the script "gtkEmbed" and it launches "gtkEmbed-bin"
Call the script "foo" and it launches "foo-bin"
Reporter | ||
Comment 5•24 years ago
|
||
I don't see a great savings here, this script shouldn't
be changing that much. I vote for keeping things easy
and just clone a copy of the mozilla script for the embed case.
I disagree. The run-mozilla.sh has a single line of code at the top which
determines what executable binary is launched. It shouldn't too great an effort
to modify this to first test for $0-bin and only default to mozilla-bin if that
doesn't exist.
e.g. instead of:
cmdname=`basename $0`
MOZ_DIST_BIN=`dirname $0`
MOZ_APPRUNNER_NAME="./mozilla-bin"
write:
cmdname=`basename $0`
MOZ_DIST_BIN=`dirname $0`
MOZ_APPRUNNER_NAME="./$cmdname-bin"
if [ ! -x $MOZ_APPRUNNER_NAME ]; then
MOZ_APPRUNNER_NAME="./mozilla-bin"
fi
Then we can copy run-mozilla.sh as gtkEmbed and it will automatically try to
launch gtkEmbed-bin when it's invoked.
Reporter | ||
Comment 7•24 years ago
|
||
ok your suggestion will work.
This script need to live in both
dist/bin and dist/Embed, any problems
with that? I guess this could be linked
as part of the embed make process.
Embedding already copies run-mozilla.sh to $(DIST)/Embed so it should be no big
deal to copy it as "gtkEmbed". The existing gtkEmbed would need to be renamed
gtkEmbed-bin. We've had bad experiences with file linking so a straight copy
would be best.
Another solution is we just tell people to type "./run-mozilla.sh gtkEmbed"
which works right now.
Assignee | ||
Comment 10•24 years ago
|
||
The patch changes run-mozilla.sh slightly so that running it with no arguments
will make it search for $0-bin, viewer and then mozilla to use as the default
executable name.
Updated•24 years ago
|
Target Milestone: mozilla0.9 → mozilla1.0
Comment 11•24 years ago
|
||
Thanks for the patch; we need something like this. I do not know this code
(script) well enough to give it an r=. Know a good script person? Thanks.
Comment 12•24 years ago
|
||
kandrot embedding bugs to valeski.
Assignee: kandrot → valeski
Status: ASSIGNED → NEW
Target Milestone: mozilla1.0 → ---
Comment 13•24 years ago
|
||
invalidating. gtkEmbed is no longer used.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → INVALID
Assignee | ||
Comment 14•24 years ago
|
||
Reopening and resummarizing.
The problem here is we a script called run-mozilla.sh with a hardcoded reference
to mozilla-bin. It can be made more useful if it tried to launch $0-bin instead.
For example if the script were called "mozilla", it would try and launch
"mozilla-bin". If it were called "foo" it would launch "foo-bin".
The patch puts this functionality in.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Summary: gtkEmbed should be a script that calls gtkEmbed-bin → run-mozilla.sh has hardcoded reference to mozilla-bin
Comment 15•24 years ago
|
||
what are we waiting for on this then?
Assignee | ||
Comment 16•24 years ago
|
||
I'll produce a new patch and submit for review
Assignee: valeski → adamlock
Status: REOPENED → NEW
Assignee | ||
Comment 17•24 years ago
|
||
Assignee | ||
Comment 18•24 years ago
|
||
Jud, can you review this patch?
Assignee | ||
Comment 19•24 years ago
|
||
Oops, CC'ing Jud. Jud can you review this patch?
Comment 20•24 years ago
|
||
Comment on attachment 48079 [details] [diff] [review]
Updated patch for run-mozilla.sh adds some comments
r=valeski
Attachment #48079 -
Flags: review+
Comment 21•24 years ago
|
||
+MOZ_DEFAULT_NAME="./$cmdname-bin"
Can you use ${cmdname} instead there? Otherwise sr=blizzard
Assignee | ||
Comment 22•24 years ago
|
||
Fix is checked in
Status: NEW → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•