Closed Bug 707629 Opened 8 years ago Closed 8 years ago

Complete mozTelephony call API functionality

Categories

(Core :: DOM: Device Interfaces, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: philikon, Assigned: philikon)

References

Details

Attachments

(3 files)

This includes reflecting callstate properly, dispatching the relevant events, and supporting functionality like hanging up.
Assignee: nobody → philipp
Attachment #579572 - Flags: review?(gal)
Attached file very simple HTML phone
Here's the simplest possible HTML demo for this API (and it works!)
Comment on attachment 579573 [details] [diff] [review]
Part 2 (v1): Complete most of the mozTelephony API

I should mention some of the deficiencies in this patch:

* Not all call state transitions are notified at this point. Only the ones initiated by the radio are. The ones that would be initiated by the user (e.g. by answering or hanging up the phone, IOW "connecting" and "disconnecting") aren't notified yet.

* I haven't implemented mozIDOMTelephonyCallEvent. I'm not even sure I can in JS. So 'event.call' will be undefined.

* We could and should be verifying assumptions in more places. See the TODO statements in the code.

Also, please ignore the dump() calls, I already removed them but forgot to refresh the patch.
Comment on attachment 579572 [details] [diff] [review]
Part 1 (v1): Call state handling & manipulation

Review of attachment 579572 [details] [diff] [review]:
-----------------------------------------------------------------

Please make sure to flag as "TODO:" all the missing parts you have in your head. We will iterate on this further, looks great so far.
Attachment #579572 - Flags: review?(gal) → review+
Comment on attachment 579573 [details] [diff] [review]
Part 2 (v1): Complete most of the mozTelephony API

Review of attachment 579573 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me!
Attachment #579573 - Flags: review?(bent.mozilla) → review+
(Bug was ambitiously named, this was really only about call functionality. Still missing audio stuff like muting, speaker, volume, DTMF tones, etc. Will file a follow-up bug for those.)
Summary: Complete mozTelephony API functionality → Complete mozTelephony call API functionality
https://hg.mozilla.org/mozilla-central/rev/c634c79dd829
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Component: DOM → DOM: Device Interfaces
QA Contact: general → device-interfaces
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.