707629 - Complete mozTelephony call API functionality

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Philipp von Weitershausen [:philikon]]

This includes reflecting callstate properly, dispatching the relevant events, and supporting functionality like hanging up.

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: Part 1 (v1): Call state handling & manipulation

Comment 2

[Philipp von Weitershausen [:philikon]]

Attachment: Part 2 (v1): Complete most of the mozTelephony API

Comment 3

[Philipp von Weitershausen [:philikon]]

Attachment: very simple HTML phone

Here's the simplest possible HTML demo for this API (and it works!)

Comment 4

[Philipp von Weitershausen [:philikon]]

Comment on attachment 579573 [details] [diff] [review]
Part 2 (v1): Complete most of the mozTelephony API

I should mention some of the deficiencies in this patch:

* Not all call state transitions are notified at this point. Only the ones initiated by the radio are. The ones that would be initiated by the user (e.g. by answering or hanging up the phone, IOW "connecting" and "disconnecting") aren't notified yet.

* I haven't implemented mozIDOMTelephonyCallEvent. I'm not even sure I can in JS. So 'event.call' will be undefined.

* We could and should be verifying assumptions in more places. See the TODO statements in the code.

Also, please ignore the dump() calls, I already removed them but forgot to refresh the patch.

Comment 5

[Andreas Gal :gal]

Comment on attachment 579572 [details] [diff] [review]
Part 1 (v1): Call state handling & manipulation

Review of attachment 579572 [details] [diff] [review]:
-----------------------------------------------------------------

Please make sure to flag as "TODO:" all the missing parts you have in your head. We will iterate on this further, looks great so far.

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 579573 [details] [diff] [review]
Part 2 (v1): Complete most of the mozTelephony API

Review of attachment 579573 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me!

Comment 7

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c634c79dd829
https://hg.mozilla.org/integration/mozilla-inbound/rev/40d760a40100

Comment 8

[Philipp von Weitershausen [:philikon]]

(Bug was ambitiously named, this was really only about call functionality. Still missing audio stuff like muting, speaker, volume, DTMF tones, etc. Will file a follow-up bug for those.)

Comment 9

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/c634c79dd829

Comment 10

[Matt Brubeck (:mbrubeck)]

and I forgot to paste https://hg.mozilla.org/mozilla-central/rev/40d760a40100