Last Comment Bug 707629 - Complete mozTelephony call API functionality
: Complete mozTelephony call API functionality
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: Trunk
: All Gonk (Firefox OS)
: -- normal (vote)
: mozilla11
Assigned To: Philipp von Weitershausen [:philikon]
:
Mentors:
Depends on:
Blocks: b2g-telephony
  Show dependency treegraph
 
Reported: 2011-12-05 03:30 PST by Philipp von Weitershausen [:philikon]
Modified: 2011-12-16 13:53 PST (History)
7 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Part 1 (v1): Call state handling & manipulation (20.47 KB, patch)
2011-12-06 20:08 PST, Philipp von Weitershausen [:philikon]
gal: review+
Details | Diff | Review
Part 2 (v1): Complete most of the mozTelephony API (21.96 KB, patch)
2011-12-06 20:09 PST, Philipp von Weitershausen [:philikon]
bent.mozilla: review+
Details | Diff | Review
very simple HTML phone (1.05 KB, text/html)
2011-12-06 20:14 PST, Philipp von Weitershausen [:philikon]
no flags Details

Description Philipp von Weitershausen [:philikon] 2011-12-05 03:30:22 PST
This includes reflecting callstate properly, dispatching the relevant events, and supporting functionality like hanging up.
Comment 1 Philipp von Weitershausen [:philikon] 2011-12-06 20:08:30 PST
Created attachment 579572 [details] [diff] [review]
Part 1 (v1): Call state handling & manipulation
Comment 2 Philipp von Weitershausen [:philikon] 2011-12-06 20:09:10 PST
Created attachment 579573 [details] [diff] [review]
Part 2 (v1): Complete most of the mozTelephony API
Comment 3 Philipp von Weitershausen [:philikon] 2011-12-06 20:14:00 PST
Created attachment 579575 [details]
very simple HTML phone

Here's the simplest possible HTML demo for this API (and it works!)
Comment 4 Philipp von Weitershausen [:philikon] 2011-12-06 20:30:55 PST
Comment on attachment 579573 [details] [diff] [review]
Part 2 (v1): Complete most of the mozTelephony API

I should mention some of the deficiencies in this patch:

* Not all call state transitions are notified at this point. Only the ones initiated by the radio are. The ones that would be initiated by the user (e.g. by answering or hanging up the phone, IOW "connecting" and "disconnecting") aren't notified yet.

* I haven't implemented mozIDOMTelephonyCallEvent. I'm not even sure I can in JS. So 'event.call' will be undefined.

* We could and should be verifying assumptions in more places. See the TODO statements in the code.

Also, please ignore the dump() calls, I already removed them but forgot to refresh the patch.
Comment 5 Andreas Gal :gal 2011-12-06 21:44:16 PST
Comment on attachment 579572 [details] [diff] [review]
Part 1 (v1): Call state handling & manipulation

Review of attachment 579572 [details] [diff] [review]:
-----------------------------------------------------------------

Please make sure to flag as "TODO:" all the missing parts you have in your head. We will iterate on this further, looks great so far.
Comment 6 Ben Turner (not reading bugmail, use the needinfo flag!) 2011-12-06 22:14:45 PST
Comment on attachment 579573 [details] [diff] [review]
Part 2 (v1): Complete most of the mozTelephony API

Review of attachment 579573 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me!
Comment 8 Philipp von Weitershausen [:philikon] 2011-12-06 23:45:56 PST
(Bug was ambitiously named, this was really only about call functionality. Still missing audio stuff like muting, speaker, volume, DTMF tones, etc. Will file a follow-up bug for those.)
Comment 9 Matt Brubeck (:mbrubeck) 2011-12-07 12:21:36 PST
https://hg.mozilla.org/mozilla-central/rev/c634c79dd829
Comment 10 Matt Brubeck (:mbrubeck) 2011-12-07 12:22:05 PST
and I forgot to paste https://hg.mozilla.org/mozilla-central/rev/40d760a40100

Note You need to log in before you can comment on or make changes to this bug.