Closed
Bug 707629
Opened 13 years ago
Closed 13 years ago
Complete mozTelephony call API functionality
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: philikon, Assigned: philikon)
References
Details
Attachments
(3 files)
20.47 KB,
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
21.96 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
1.05 KB,
text/html
|
Details |
This includes reflecting callstate properly, dispatching the relevant events, and supporting functionality like hanging up.
Assignee | ||
Comment 1•13 years ago
|
||
Assignee: nobody → philipp
Attachment #579572 -
Flags: review?(gal)
Assignee | ||
Comment 3•13 years ago
|
||
Here's the simplest possible HTML demo for this API (and it works!)
Assignee | ||
Comment 4•13 years ago
|
||
Comment on attachment 579573 [details] [diff] [review] Part 2 (v1): Complete most of the mozTelephony API I should mention some of the deficiencies in this patch: * Not all call state transitions are notified at this point. Only the ones initiated by the radio are. The ones that would be initiated by the user (e.g. by answering or hanging up the phone, IOW "connecting" and "disconnecting") aren't notified yet. * I haven't implemented mozIDOMTelephonyCallEvent. I'm not even sure I can in JS. So 'event.call' will be undefined. * We could and should be verifying assumptions in more places. See the TODO statements in the code. Also, please ignore the dump() calls, I already removed them but forgot to refresh the patch.
Comment 5•13 years ago
|
||
Comment on attachment 579572 [details] [diff] [review] Part 1 (v1): Call state handling & manipulation Review of attachment 579572 [details] [diff] [review]: ----------------------------------------------------------------- Please make sure to flag as "TODO:" all the missing parts you have in your head. We will iterate on this further, looks great so far.
Attachment #579572 -
Flags: review?(gal) → review+
Comment on attachment 579573 [details] [diff] [review] Part 2 (v1): Complete most of the mozTelephony API Review of attachment 579573 [details] [diff] [review]: ----------------------------------------------------------------- Looks fine to me!
Attachment #579573 -
Flags: review?(bent.mozilla) → review+
Assignee | ||
Comment 7•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c634c79dd829 https://hg.mozilla.org/integration/mozilla-inbound/rev/40d760a40100
Assignee | ||
Comment 8•13 years ago
|
||
(Bug was ambitiously named, this was really only about call functionality. Still missing audio stuff like muting, speaker, volume, DTMF tones, etc. Will file a follow-up bug for those.)
Summary: Complete mozTelephony API functionality → Complete mozTelephony call API functionality
Comment 9•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c634c79dd829
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Comment 10•13 years ago
|
||
and I forgot to paste https://hg.mozilla.org/mozilla-central/rev/40d760a40100
Assignee | ||
Updated•13 years ago
|
Component: DOM → DOM: Device Interfaces
QA Contact: general → device-interfaces
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•