707634 - Missing specializations of float4 constructor

Status: VERIFIED FIXED

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect, P2)

Description

[Lars T Hansen]

The float4 constructor is currently specialized if the arguments are constant values.  But when they are not, then we take the slow path: convert everything to atom, call out to the generic constructor.  This is much worse than it needs to be, and a performance drain.

We should at least handle the case where the arguments are known to be Number (including int and uint) or float.  In this case, there should be in-line conversions to float, and an in-line construction of a float4 datum.

The same is true for one argument that is not a constant.

Comment 1

[Lars T Hansen]

It appears that the one-argument case is handled properly for int, float, and Number argument values, which are the ones we care about most.

Comment 2

[Virgil Palanciuc]

Fixed starting with changeset 7037:f72cddd20bf0

Comment 3

[Brent Baker]

Is there any way to test this or can this just be verified by code landing and acceptance and other tests passing?

Comment 4

[Virgil Palanciuc]

I guess there could be a performance tests too (constructing float4 values in a loop, based on the value of the loop index?)

Comment 5

[Tamarin Bot]

changeset: 7060:acdb8ce31ff7
user:      Virgil Palanciuc <[e-mail]>
summary:   bugfix for https://bugzilla.mozilla.org/show_bug.cgi?id=707634

http://hg.mozilla.org/tamarin-redux/rev/acdb8ce31ff7