707677 - Use defaultPrevented instead of the deprecated getPreventDefault() in front-end code

Status: VERIFIED FIXED

(Core :: General, defect)

Description

[Dão Gottwald [:dao]]

event.getPreventDefault is deprecated, we should use event.defaultPrevented instead.

Affected files:

http://mxr.mozilla.org/mozilla-central/search?string=getPreventDefault&case=1&find=&findi=&filter=\.%28js|xml|xul|html%29&hitlimit=&tree=mozilla-central

Comment 1

[Jan Bambach [:Jan]]

Attachment: This patch should fix Bug 707677.

Comment 2

[Dão Gottwald [:dao]]

Did you intentionally leave out content/events/test/test_bug508906.html and content/xul/content/test/test_bug486990.xul?

In browser/base/content/browser-places.js and content/events/test/test_bug493251.html there are comments referring to getPreventDefault(), by the way -- those should be updated as well.

Comment 3

[Dão Gottwald [:dao]]

Also, you seem to have missed one instance in toolkit/content/widgets/wizard.xml as well as toolkit/content/widgets/dialog.xml.

Comment 4

[Jan Bambach [:Jan]]

Attachment: This patch should fix Bug 707677.

Comment 5

[Jan Bambach [:Jan]]

Attachment: Adding the name to the contributors section. (Optional)

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 579799 [details] [diff] [review]
This patch should fix Bug 707677.

Thanks!

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 579801 [details] [diff] [review]
Adding the name to the contributors section. (Optional)

I think we probably shouldn't do this for non-invasive search-and-replace changes. For instance, when another contributor wants to do something in b2g/chrome/content/shell.js and is looking for guidance, you probably wouldn't want that contributor to contact you just because you're in the contributors section of that file.

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/ccc5f03e6dd2

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ccc5f03e6dd2

Comment 10

[Jan Bambach [:Jan]]

Thanks a lot! :-) -> Verified