Closed Bug 707677 Opened 12 years ago Closed 12 years ago

Use defaultPrevented instead of the deprecated getPreventDefault() in front-end code

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla11

People

(Reporter: dao, Assigned: jan)

References

Details

(Whiteboard: [good first bug][mentor=dao][lang=js])

Attachments

(1 file, 2 obsolete files)

This patch should fix Bug 707677.
16.87 KB, patch
dao
: review+
Details | Diff | Splinter Review 
event.getPreventDefault is deprecated, we should use event.defaultPrevented instead.

Affected files:

http://mxr.mozilla.org/mozilla-central/search?string=getPreventDefault&case=1&find=&findi=&filter=\.%28js|xml|xul|html%29&hitlimit=&tree=mozilla-central
Assignee: nobody → jan.bambach
Status: NEW → ASSIGNED

    
  

        Attachment #579132 -
        Flags: review?

    
  

        Attachment #579132 -
        Flags: review? → review?(dao)

    
    

    
  
Did you intentionally leave out content/events/test/test_bug508906.html and content/xul/content/test/test_bug486990.xul?

In browser/base/content/browser-places.js and content/events/test/test_bug493251.html there are comments referring to getPreventDefault(), by the way -- those should be updated as well.

    
    

    
  
Also, you seem to have missed one instance in toolkit/content/widgets/wizard.xml as well as toolkit/content/widgets/dialog.xml.

    
  

        Attachment #579132 -
        Attachment is obsolete: true

        Attachment #579132 -
        Flags: review?(dao)

    
    

    
  


  

        Attachment #579799 -
        Flags: review?(dao)

    
    

    
  


  

        Attachment #579801 -
        Flags: review?(dao)

    
    

    
  
Comment on attachment 579799 [details] [diff] [review]
This patch should fix Bug 707677.

Thanks!

        Attachment #579799 -
        Flags: review?(dao) → review+

    
    

    
  
Comment on attachment 579801 [details] [diff] [review]
Adding the name to the contributors section. (Optional)

I think we probably shouldn't do this for non-invasive search-and-replace changes. For instance, when another contributor wants to do something in b2g/chrome/content/shell.js and is looking for guidance, you probably wouldn't want that contributor to contact you just because you're in the contributors section of that file.

        Attachment #579801 -
        Attachment is obsolete: true

        Attachment #579801 -
        Flags: review?(dao)

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/ccc5f03e6dd2
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

    
    

    
  
Thanks a lot! :-) -> Verified
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.