The default bug view has changed. See this FAQ.

Add more sampler labels

RESOLVED FIXED in mozilla11

Status

()

Core
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

unspecified
mozilla11
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Snappy:P1])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 579140 [details] [diff] [review]
Add a bunch of labels that should help
Attachment #579140 - Flags: review?(bgirard)
(Assignee)

Updated

5 years ago
Whiteboard: [Snappy:P1]

Updated

5 years ago
Attachment #579140 - Flags: review?(bgirard) → review+
(Assignee)

Comment 1

5 years ago
Created attachment 579773 [details] [diff] [review]
Add a bunch of labels that should help v2
Attachment #579140 - Attachment is obsolete: true
Attachment #579773 - Flags: review?

Updated

5 years ago
Attachment #579773 - Flags: review? → review+
(Assignee)

Comment 2

5 years ago
Created attachment 579791 [details] [diff] [review]
Rename SAMPLE_CHECKPOINT to SAMPLE_LABEL
Attachment #579791 - Flags: review?(bgirard)
Comment on attachment 579791 [details] [diff] [review]
Rename SAMPLE_CHECKPOINT to SAMPLE_LABEL

You should fold these patch IMO
Attachment #579791 - Flags: review?(bgirard) → review+
I missed that you added:
'#define SAMPLER_RESPONSIVENESS(time)' to one of the patch. I don't think this should go in the tree.
Please set assignee when attaching or else when landed :-)

https://hg.mozilla.org/mozilla-central/rev/3de0addfa544
https://hg.mozilla.org/mozilla-central/rev/c79de7ae8a57
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Comment on attachment 579773 [details] [diff] [review]
Add a bunch of labels that should help v2


>@@ -3191,6 +3197,7 @@ nsJSContext::CycleCollectNow(nsICycleCollectorListener *aListener)
>     return;
>   }
> 
>+  SAMPLE_LABEL("GC", "CycleCollectNow");

I don't know what the first parameter means, but
why does CycleCollectNow have "GC"?
Cycle collection is cycle collection, not garbage collection.

>diff --git a/xpcom/threads/nsTimerImpl.cpp b/xpcom/threads/nsTimerImpl.cpp
>index 90d122f..3884b17 100644
>--- a/xpcom/threads/nsTimerImpl.cpp
>+++ b/xpcom/threads/nsTimerImpl.cpp
>@@ -44,6 +44,7 @@
> #include "nsThreadManager.h"
> #include "nsThreadUtils.h"
> #include "prmem.h"
>+#include "sampler.h"
> 
> using mozilla::TimeDuration;
> using mozilla::TimeStamp;
>@@ -376,6 +377,8 @@ void nsTimerImpl::Fire()
>   if (mCanceled)
>     return;
> 
>+  SAMPLE_LABEL("Timer", "Fire");
>+
Did any xpcom peer actually review this? Is it ok that xpcom/ depends always on tools/? I would have assumed some #ifdef was needed.
You need to log in before you can comment on or make changes to this bug.