707800 - Add more sampler labels

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: Add a bunch of labels that should help

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Add a bunch of labels that should help v2

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Rename SAMPLE_CHECKPOINT to SAMPLE_LABEL

Comment 3

[Benoit Girard (:BenWa)]

Comment on attachment 579791 [details] [diff] [review]
Rename SAMPLE_CHECKPOINT to SAMPLE_LABEL

You should fold these patch IMO

Comment 4

[Benoit Girard (:BenWa)]

I missed that you added:
'#define SAMPLER_RESPONSIVENESS(time)' to one of the patch. I don't think this should go in the tree.

Comment 5

[Ed Morley [:emorley]]

Please set assignee when attaching or else when landed :-)

https://hg.mozilla.org/mozilla-central/rev/3de0addfa544
https://hg.mozilla.org/mozilla-central/rev/c79de7ae8a57

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 579773 [details] [diff] [review]
Add a bunch of labels that should help v2


>@@ -3191,6 +3197,7 @@ nsJSContext::CycleCollectNow(nsICycleCollectorListener *aListener)
>     return;
>   }
> 
>+  SAMPLE_LABEL("GC", "CycleCollectNow");

I don't know what the first parameter means, but
why does CycleCollectNow have "GC"?
Cycle collection is cycle collection, not garbage collection.

>diff --git a/xpcom/threads/nsTimerImpl.cpp b/xpcom/threads/nsTimerImpl.cpp
>index 90d122f..3884b17 100644
>--- a/xpcom/threads/nsTimerImpl.cpp
>+++ b/xpcom/threads/nsTimerImpl.cpp
>@@ -44,6 +44,7 @@
> #include "nsThreadManager.h"
> #include "nsThreadUtils.h"
> #include "prmem.h"
>+#include "sampler.h"
> 
> using mozilla::TimeDuration;
> using mozilla::TimeStamp;
>@@ -376,6 +377,8 @@ void nsTimerImpl::Fire()
>   if (mCanceled)
>     return;
> 
>+  SAMPLE_LABEL("Timer", "Fire");
>+
Did any xpcom peer actually review this? Is it ok that xpcom/ depends always on tools/? I would have assumed some #ifdef was needed.