Last Comment Bug 707870 - nsDOMEventTargetHelper should Disconnect mListenerManager itself
: nsDOMEventTargetHelper should Disconnect mListenerManager itself
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla11
Assigned To: Mounir Lamouri (:mounir)
: Andrew Overholt [:overholt]
Depends on:
Blocks: websms
  Show dependency treegraph
Reported: 2011-12-05 20:13 PST by Mounir Lamouri (:mounir)
Modified: 2011-12-08 08:28 PST (History)
2 users (show)
mounir: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch v1 (14.24 KB, patch)
2011-12-05 20:13 PST, Mounir Lamouri (:mounir)
no flags Details | Diff | Splinter Review
Patch v1.1 (12.90 KB, patch)
2011-12-06 18:20 PST, Mounir Lamouri (:mounir)
bugs: review+
mounir: checkin+
Details | Diff | Splinter Review

Description User image Mounir Lamouri (:mounir) 2011-12-05 20:13:25 PST
Created attachment 579212 [details] [diff] [review]
Patch v1

I don't know if it is expected that mListenerManager has to be disconnected by class inheriting from nsDOMEventTargetHelper but that seems a very bad design because developers writing code for those class don't know at a first glance this is needed. In addition, most usage consist of disconnecting in the inherited class dtor so we could just do that in nsDOMEventTargetHelper dtor. Disconnecting at another moment will still work.
Comment 1 User image Mounir Lamouri (:mounir) 2011-12-06 18:20:04 PST
Created attachment 579562 [details] [diff] [review]
Patch v1.1

WindowRoot is actually creating its own mListenerManager instance.
Comment 2 User image Ed Morley [:emorley] 2011-12-08 08:28:22 PST

Note You need to log in before you can comment on or make changes to this bug.