The default bug view has changed. See this FAQ.

nsDOMEventTargetHelper should Disconnect mListenerManager itself

RESOLVED FIXED in mozilla11

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla11
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 579212 [details] [diff] [review]
Patch v1

I don't know if it is expected that mListenerManager has to be disconnected by class inheriting from nsDOMEventTargetHelper but that seems a very bad design because developers writing code for those class don't know at a first glance this is needed. In addition, most usage consist of disconnecting in the inherited class dtor so we could just do that in nsDOMEventTargetHelper dtor. Disconnecting at another moment will still work.
Attachment #579212 - Flags: review?(bugs)
(Assignee)

Comment 1

5 years ago
Created attachment 579562 [details] [diff] [review]
Patch v1.1

WindowRoot is actually creating its own mListenerManager instance.
Attachment #579212 - Attachment is obsolete: true
Attachment #579212 - Flags: review?(bugs)
Attachment #579562 - Flags: review?(bugs)

Updated

5 years ago
Attachment #579562 - Flags: review?(bugs) → review+
(Assignee)

Updated

5 years ago
Flags: in-testsuite-
Whiteboard: [needs review]
Target Milestone: --- → mozilla11
(Assignee)

Updated

5 years ago
Attachment #579562 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/647b56f040f1
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.