Closed Bug 707870 Opened 8 years ago Closed 8 years ago

nsDOMEventTargetHelper should Disconnect mListenerManager itself

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: mounir, Assigned: mounir)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch v1 (obsolete) — Splinter Review
I don't know if it is expected that mListenerManager has to be disconnected by class inheriting from nsDOMEventTargetHelper but that seems a very bad design because developers writing code for those class don't know at a first glance this is needed. In addition, most usage consist of disconnecting in the inherited class dtor so we could just do that in nsDOMEventTargetHelper dtor. Disconnecting at another moment will still work.
Attachment #579212 - Flags: review?(bugs)
Attached patch Patch v1.1Splinter Review
WindowRoot is actually creating its own mListenerManager instance.
Attachment #579212 - Attachment is obsolete: true
Attachment #579212 - Flags: review?(bugs)
Attachment #579562 - Flags: review?(bugs)
Attachment #579562 - Flags: review?(bugs) → review+
Flags: in-testsuite-
Whiteboard: [needs review]
Target Milestone: --- → mozilla11
Attachment #579562 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/647b56f040f1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.