Last Comment Bug 707883 - Rename and move around dom/telephony to be more generic
: Rename and move around dom/telephony to be more generic
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: Blake Kaplan (:mrbkap) (PTO until Jan. 2, 2017)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks: b2g-telephony
  Show dependency treegraph
 
Reported: 2011-12-05 22:11 PST by Blake Kaplan (:mrbkap) (PTO until Jan. 2, 2017)
Modified: 2012-02-01 13:58 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Rename Radio -> RadioManager (9.03 KB, patch)
2011-12-05 22:22 PST, Blake Kaplan (:mrbkap) (PTO until Jan. 2, 2017)
bent.mozilla: review+
mrbkap: checkin+
Details | Diff | Splinter Review
Move RadioManager into dom/system/b2g and make dom/telephony just telephone stuff (10.80 KB, patch)
2011-12-05 22:24 PST, Blake Kaplan (:mrbkap) (PTO until Jan. 2, 2017)
bent.mozilla: review+
mrbkap: checkin+
Details | Diff | Splinter Review
Rename nsIRadio{Interface,Callback} -> nsITelephone{Interface,Callback} (9.39 KB, patch)
2011-12-05 22:38 PST, Blake Kaplan (:mrbkap) (PTO until Jan. 2, 2017)
no flags Details | Diff | Splinter Review
Rename nsIRadio{Interface,Callback} -> nsITelephone{Interface,Callback} (10.17 KB, patch)
2011-12-05 23:15 PST, Blake Kaplan (:mrbkap) (PTO until Jan. 2, 2017)
bent.mozilla: review+
mrbkap: checkin+
Details | Diff | Splinter Review
Rename nsITelephonyWorker -> nsIRadioWorker (6.43 KB, patch)
2011-12-06 00:50 PST, Blake Kaplan (:mrbkap) (PTO until Jan. 2, 2017)
bent.mozilla: review+
mrbkap: checkin+
Details | Diff | Splinter Review

Description Blake Kaplan (:mrbkap) (PTO until Jan. 2, 2017) 2011-12-05 22:11:49 PST

    
Comment 1 Blake Kaplan (:mrbkap) (PTO until Jan. 2, 2017) 2011-12-05 22:22:21 PST
Created attachment 579235 [details] [diff] [review]
Rename Radio -> RadioManager
Comment 2 Blake Kaplan (:mrbkap) (PTO until Jan. 2, 2017) 2011-12-05 22:24:32 PST
Created attachment 579236 [details] [diff] [review]
Move RadioManager into dom/system/b2g and make dom/telephony just telephone stuff
Comment 3 Blake Kaplan (:mrbkap) (PTO until Jan. 2, 2017) 2011-12-05 22:38:48 PST
Created attachment 579238 [details] [diff] [review]
Rename nsIRadio{Interface,Callback} -> nsITelephone{Interface,Callback}
Comment 4 Blake Kaplan (:mrbkap) (PTO until Jan. 2, 2017) 2011-12-05 23:15:15 PST
Created attachment 579244 [details] [diff] [review]
Rename nsIRadio{Interface,Callback} -> nsITelephone{Interface,Callback}

Oops. I forgot to rename the member and function names last time around.
Comment 5 Blake Kaplan (:mrbkap) (PTO until Jan. 2, 2017) 2011-12-06 00:50:50 PST
Created attachment 579258 [details] [diff] [review]
Rename nsITelephonyWorker -> nsIRadioWorker

So, in order to keep individual worker CIDs with their respective code, this requires workers to be accompanied by a .h file.
Comment 6 Ben Turner (not reading bugmail, use the needinfo flag!) 2011-12-06 00:54:17 PST
Comment on attachment 579258 [details] [diff] [review]
Rename nsITelephonyWorker -> nsIRadioWorker

Excellent diff, git. Really excellent.

Note You need to log in before you can comment on or make changes to this bug.