Closed
Bug 707911
Opened 13 years ago
Closed 12 years ago
Rewrite StackTraceToString to use StringBuffer
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: evilpie, Assigned: evilpie)
Details
Attachments
(1 file)
6.84 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•13 years ago
|
Assignee: general → evilpies
Assignee | ||
Comment 1•12 years ago
|
||
I think this works around the problem in the old version of this. So before I try to add name, line and file for a new StackFrame, I first try to reserve that space, this way we shouldn't OOM while adding either name, line or file and all entries should be correct. I also kept around the length limit.
Assignee | ||
Updated•12 years ago
|
Attachment #624124 -
Flags: review?(bhackett1024)
Comment 2•12 years ago
|
||
Comment on attachment 624124 [details] [diff] [review] v1 Review of attachment 624124 [details] [diff] [review]: ----------------------------------------------------------------- Nice cleanup. ::: js/src/jit-test/tests/basic/bug707911.js @@ +12,5 @@ > + /* oom should not cause abort, but instead just shorten the stacktrace */ > +} catch (e) { > + /* we assume at least one entry make it into the stack */ > + assertEq(e.stack.indexOf('a@') >= 0, true); > +} Without a value for -A this test won't trigger an OOM while constructing the stack trace, it will hit recursion limits long before. Either fix the test or remove it.
Attachment #624124 -
Flags: review?(bhackett1024) → review+
Assignee | ||
Comment 3•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/20b27f266d73
Assignee | ||
Updated•12 years ago
|
Target Milestone: --- → mozilla15
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/20b27f266d73
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•