Closed Bug 707929 Opened 12 years ago Closed 12 years ago

java.lang.NullPointerException @ ZipFile.getInputStream(ZipFile.java:256)

Categories

(Firefox for Android Graveyard :: General, defect, P3)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect

Tracking

(firefox11 fixed, fennec11+)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox11 --- fixed
fennec 11+ ---

People

(Reporter: aaronmt, Assigned: blassey)

Details

(Keywords: crash, Whiteboard: [native-crash])

Attachments

(1 file)

patch
1.34 KB, patch
mfinkle
: review+
Details | Diff | Splinter Review 
I/GeckoAddons(  800): java.lang.NullPointerException
I/GeckoAddons(  800): 	at java.util.zip.ZipFile.getInputStream(ZipFile.java:256)
I/GeckoAddons(  800): 	at org.mozilla.gecko.AboutHomeContent.getRecommendedAddonsStream(AboutHomeContent.java:177)
I/GeckoAddons(  800): 	at org.mozilla.gecko.AboutHomeContent$4.run(AboutHomeContent.java:185)
I/GeckoAddons(  800): 	at android.os.Handler.handleCallback(Handler.java:587)
I/GeckoAddons(  800): 	at android.os.Handler.dispatchMessage(Handler.java:92)
I/GeckoAddons(  800): 	at android.os.Looper.loop(Looper.java:130)
I/GeckoAddons(  800): 	at org.mozilla.gecko.GeckoAppShell$LooperThread.run(GeckoAppShell.java:153)

On launch crash with:

20111206040208
http://hg.mozilla.org/projects/birch/rev/a7fb88bd5148
Assignee: nobody → blassey.bugs
Priority: -- → P3
(In reply to Aaron Train [:aaronmt] from comment #0)
> I/GeckoAddons(  800): java.lang.NullPointerException
> I/GeckoAddons(  800): 	at
> java.util.zip.ZipFile.getInputStream(ZipFile.java:256)
> I/GeckoAddons(  800): 	at
> org.mozilla.gecko.AboutHomeContent.
> getRecommendedAddonsStream(AboutHomeContent.java:177)
> I/GeckoAddons(  800): 	at
> org.mozilla.gecko.AboutHomeContent$4.run(AboutHomeContent.java:185)
> I/GeckoAddons(  800): 	at android.os.Handler.handleCallback(Handler.java:587)
> I/GeckoAddons(  800): 	at android.os.Handler.dispatchMessage(Handler.java:92)
> I/GeckoAddons(  800): 	at android.os.Looper.loop(Looper.java:130)
> I/GeckoAddons(  800): 	at
> org.mozilla.gecko.GeckoAppShell$LooperThread.run(GeckoAppShell.java:153)
> 
> On launch crash with:
> 
> 20111206040208
> http://hg.mozilla.org/projects/birch/rev/a7fb88bd5148

how is this a crash? It is inside a blanket try-catch. If you are actually crashing, this is not the reason, so please attach a bigger log.
I don't see this anymore.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WORKSFORME
Attached patch patch — — Splinter Review 
even though this is not a crash, I do not like throwing unnecessarily, so here are some null checks
Attachment #581429 - Flags: review?(mark.finkle)
Attachment #581429 - Flags: review?(mark.finkle) → review+
tracking-fennec: --- → 11+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.