The trigger causes more damage than gains, thanks to the keywords cache we already know if a keyword should be removed, no reason to trigger on each bookmark removal.
Created attachment 579484 [details] [diff] [review] patch v1.0 Removes the trigger and uses the cache to check if a keyword may exist, if so tries to remove it. Will have to serialize this with the other schema changes, not a big deal though.
Attachment #579484 - Flags: review?(dietrich)
Attachment #579484 - Flags: review?(dietrich) → review+
Target Milestone: --- → mozilla11
followup to fix a test. Since keyword removal from the database is async the test was checking too early https://hg.mozilla.org/integration/mozilla-inbound/rev/4c08eba40372
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.