Closed Bug 707945 Opened 8 years ago Closed 8 years ago

Remove the keywords trigger

Categories

(Toolkit :: Places, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: mak, Assigned: mak)

References

Details

(Keywords: perf)

Attachments

(1 file)

The trigger causes more damage than gains, thanks to the keywords cache we already know if a keyword should be removed, no reason to trigger on each bookmark removal.
Attached patch patch v1.0Splinter Review
Removes the trigger and uses the cache to check if a keyword may exist, if so tries to remove it.
Will have to serialize this with the other schema changes, not a big deal though.
Attachment #579484 - Flags: review?(dietrich)
Attachment #579484 - Flags: review?(dietrich) → review+
followup to fix a test.
Since keyword removal from the database is async the test was checking too early
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c08eba40372
You need to log in before you can comment on or make changes to this bug.