Closed
Bug 707945
Opened 13 years ago
Closed 13 years ago
Remove the keywords trigger
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: mak, Assigned: mak)
References
Details
(Keywords: perf)
Attachments
(1 file)
|
8.74 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
The trigger causes more damage than gains, thanks to the keywords cache we already know if a keyword should be removed, no reason to trigger on each bookmark removal.
|
Assignee | |
Comment 1•13 years ago
|
||
Removes the trigger and uses the cache to check if a keyword may exist, if so tries to remove it. Will have to serialize this with the other schema changes, not a big deal though.
Attachment #579484 -
Flags: review?(dietrich)
|
||
Updated•13 years ago
|
Attachment #579484 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3d66acea003
Target Milestone: --- → mozilla11
|
|
Assignee | |
Comment 3•13 years ago
|
||
followup to fix a test. Since keyword removal from the database is async the test was checking too early https://hg.mozilla.org/integration/mozilla-inbound/rev/4c08eba40372
|
||
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a3d66acea003 https://hg.mozilla.org/mozilla-central/rev/4c08eba40372
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•