Closed
Bug 707953
Opened 14 years ago
Closed 14 years ago
ProcessFolderNodeRow should reuse known data
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: mak, Assigned: mak)
References
Details
(Keywords: perf)
Attachments
(1 file)
|
2.50 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
ProcessFolderNodeRow causes another lookup for data that it already knows, that's avoidable by building the node differently.
|
Assignee | |
Comment 1•14 years ago
|
||
Using data we already know we save a database access
Attachment #579499 -
Flags: review?(dietrich)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 579499 [details] [diff] [review]
patch v1.0
Review of attachment 579499 [details] [diff] [review]:
-----------------------------------------------------------------
r=me
::: toolkit/components/places/nsNavBookmarks.cpp
@@ +2061,2 @@
> nsRefPtr<nsNavHistoryResultNode> node;
> +
space
Attachment #579499 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
what does this mean? I wanted to create empty space around that, cause I had really an hard time finding where we were declaring the node, that code is dense.
|
|
Assignee | |
Comment 4•14 years ago
|
||
Target Milestone: --- → mozilla11
|
||
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•