Closed Bug 707953 Opened 8 years ago Closed 8 years ago

ProcessFolderNodeRow should reuse known data

Categories

(Toolkit :: Places, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: mak, Assigned: mak)

References

Details

(Keywords: perf)

Attachments

(1 file)

ProcessFolderNodeRow causes another lookup for data that it already knows, that's avoidable by building the node differently.
Attached patch patch v1.0Splinter Review
Using data we already know we save a database access
Attachment #579499 - Flags: review?(dietrich)
Comment on attachment 579499 [details] [diff] [review]
patch v1.0

Review of attachment 579499 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: toolkit/components/places/nsNavBookmarks.cpp
@@ +2061,2 @@
>    nsRefPtr<nsNavHistoryResultNode> node;
> +

space
Attachment #579499 - Flags: review?(dietrich) → review+
what does this mean? I wanted to create empty space around that, cause I had really an hard time finding where we were declaring the node, that code is dense.
https://hg.mozilla.org/mozilla-central/rev/a0daa1a39a20
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.