Resolve covered region hack introduced in bug 614732

RESOLVED FIXED in mozilla17

Status

()

Core
SVG
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
The covered region hack introduced in bug 614732 should be eliminated to avoid doing extra work. See bug 614732 comment 32 option #1.
(Assignee)

Comment 1

6 years ago
More specifically the patch from bug 614732 comment 35 should be removed when bug 539356 is fixed.
Depends on: 539356
(Assignee)

Updated

6 years ago
Depends on: 734082
No longer depends on: 539356
(Assignee)

Updated

5 years ago
Depends on: 767823
(Assignee)

Comment 2

5 years ago
Created attachment 636181 [details] [diff] [review]
patch

Once bug 767823 is fixed, the only GetCoveredRegion caller is BoxToRect::AddBox(), via nsSVGUtils::GetOuterSVGFrameAndCoveredRegion, which is called under getBoundingClientRect/getClientRects. At that point it doesn't seem like it's worth having mCoveredRegion members on SVG leaf frames. For now we probably want to keep the GetCoveredRegion methods until we can figure out if we're going to break much content by changing them to use visual overflow rects. But I think we want getBoundingClientRect/getClientRects to act more like getBBox, in that the information is calculated on demand, rather than calculated just in case and cached the frames. This patch makes that so.
Assignee: nobody → jwatt
Status: NEW → ASSIGNED
Attachment #636181 - Flags: review?(longsonr)

Comment 3

5 years ago
Comment on attachment 636181 [details] [diff] [review]
patch

> nsSVGForeignObjectFrame::GetCoveredRegion()
...
>+  // GetCanvasTM includes the x,y translation
>+  return nsSVGUtils::TransformFrameRectToOuterSVG(gfxRect(0.0, 0.0, w, h, GetCanvasTM(), PresContext());

Nit: wrap line somewhere. Other instances are already wrapped.
Attachment #636181 - Flags: review?(longsonr) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/eec89f895133
Target Milestone: --- → mozilla17

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/eec89f895133
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.