708023 - Getting application.ini in remote talos doesn't really work

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[William Lachance (:wlach)]

Talos has a bunch of code to get the application.ini from the remote device. This doesn't actually work in most cases because the SUTAgent process is running with a different id than fennec, so doesn't have permission to get the file. The solution we have in automation is to manually copy the file from the Android .apk into the talos directory. This is fine, but the workaround is confusing when just trying to set up talos for development. The silly thing is, we don't even need the information in application.ini (build id, appname, etc.) -- it's only used when we upload information to the graphserver.

I thus propose the following solution:

1. Remove all code to get application.ini from the remote device.
2. In --develop mode, don't even bother looking for or using the info in application.ini. 
3. In production mode, demand that an application.ini file be present in the local talos directory. If it's not there, error out with a verbose error message like "application.ini not found. Please extract and copy from your Fennec apk".

Comment 1

[William Lachance (:wlach)]

Actually, the file we should be copying in the remote case is remoteapp.ini, so the error message should reflect that.

Comment 2

[Jeff Hammel]

It looks like there is no more remoteapp.ini anymore at all.  It looks like this can be closed. :jmaher?

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

correct, we don't put remoteapp.ini on the device anymore.