Closed Bug 708052 Opened 14 years ago Closed 14 years ago

combine methods to get a device manager

Categories

(Testing :: Talos, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: k0scist, Unassigned)

Details

(Whiteboard: [mozbase][good first bug][mentor=jhammel][lang=py])

Attachments

(1 file)

remotePerfConfigurator.py and ffprocess_remote.py have essentially the same logic to get a device manager: http://hg.mozilla.org/build/talos/file/b7176a4b2717/talos/remotePerfConfigurator.py#l20 http://hg.mozilla.org/build/talos/file/b7176a4b2717/talos/ffprocess_remote.py#l68 These should be combined into one utility method that lives somewhere and is consumed in these two places
Whiteboard: [mozbase][good first bug][mentor=jhammel]
Whiteboard: [mozbase][good first bug][mentor=jhammel] → [mozbase][good first bug][mentor=jhammel][lang=py]
Attachment #605564 - Flags: review?(jmaher)
Comment on attachment 605564 [details] [diff] [review] put this in utils and clean up a bit Review of attachment 605564 [details] [diff] [review]: ----------------------------------------------------------------- thanks! I was looking in the code earlier today and thought this had been done already, you beat me to it though!
Attachment #605564 - Flags: review?(jmaher) → review+
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
(btw, I tested this before committing on my phone. works fine!)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: