Closed
Bug 708052
Opened 14 years ago
Closed 13 years ago
combine methods to get a device manager
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Unassigned)
Details
(Whiteboard: [mozbase][good first bug][mentor=jhammel][lang=py])
Attachments
(1 file)
|
4.10 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
remotePerfConfigurator.py and ffprocess_remote.py have essentially the
same logic to get a device manager:
http://hg.mozilla.org/build/talos/file/b7176a4b2717/talos/remotePerfConfigurator.py#l20
http://hg.mozilla.org/build/talos/file/b7176a4b2717/talos/ffprocess_remote.py#l68
These should be combined into one utility method that lives somewhere
and is consumed in these two places
|
Reporter | |
Updated•14 years ago
|
Whiteboard: [mozbase][good first bug][mentor=jhammel]
|
|
Reporter | |
Comment 1•14 years ago
|
||
This logic also exists in run_tests.py:
http://hg.mozilla.org/build/talos/file/b7176a4b2717/talos/run_tests.py#l461
|
||
Updated•14 years ago
|
Whiteboard: [mozbase][good first bug][mentor=jhammel] → [mozbase][good first bug][mentor=jhammel][lang=py]
|
|
Reporter | |
Comment 2•13 years ago
|
||
Attachment #605564 -
Flags: review?(jmaher)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 605564 [details] [diff] [review]
put this in utils and clean up a bit
Review of attachment 605564 [details] [diff] [review]:
-----------------------------------------------------------------
thanks! I was looking in the code earlier today and thought this had been done already, you beat me to it though!
Attachment #605564 -
Flags: review?(jmaher) → review+
|
||
Comment 4•13 years ago
|
||
Pushed: http://hg.mozilla.org/build/talos/rev/9b3ca017fe4a
Thanks jhammel!
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•13 years ago
|
||
(btw, I tested this before committing on my phone. works fine!)
You need to log in
before you can comment on or make changes to this bug.
Description
•