708065 - Fix configure check for -pipe

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

With the shell used on OS X, the test we are trying to compile is

#include <stdio.h>
int main() { printf("Hello World
"); exit(0); }

which fails. Since the newline is not important for the test, we can just remove it. Note the 

checking for gcc -pipe support... no

in 

https://tbpl.mozilla.org/php/getParsedLog.php?id=7775554&tree=Try&full=1

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: Fix configure check for -pipe

https://tbpl.mozilla.org/?tree=Try&rev=4916ff7a83cf

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 579427 [details] [diff] [review]
Fix configure check for -pipe

Review of attachment 579427 [details] [diff] [review]:
-----------------------------------------------------------------

Silly. When did -pipe get added to GCC anyway? We might be able to just drop this check and use it without checking at this point.

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Good question. Looks like it was added to trunk in r60174 back in Dec 16 2002! I am not sure if all the tier2 and tier3 compilers take this option, but we can probably at least simplify the test.

I will push this to fix the immediate problem and open a new bug if needed.

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=b583dad40c36

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b583dad40c36