The default bug view has changed. See this FAQ.

Fix configure check for -pipe

RESOLVED FIXED in mozilla11

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

unspecified
mozilla11
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

With the shell used on OS X, the test we are trying to compile is

#include <stdio.h>
int main() { printf("Hello World
"); exit(0); }

which fails. Since the newline is not important for the test, we can just remove it. Note the 

checking for gcc -pipe support... no

in 

https://tbpl.mozilla.org/php/getParsedLog.php?id=7775554&tree=Try&full=1
Created attachment 579427 [details] [diff] [review]
Fix configure check for -pipe

https://tbpl.mozilla.org/?tree=Try&rev=4916ff7a83cf
Assignee: nobody → respindola
Status: NEW → ASSIGNED
Attachment #579427 - Flags: review?(ted.mielczarek)
Comment on attachment 579427 [details] [diff] [review]
Fix configure check for -pipe

Review of attachment 579427 [details] [diff] [review]:
-----------------------------------------------------------------

Silly. When did -pipe get added to GCC anyway? We might be able to just drop this check and use it without checking at this point.
Attachment #579427 - Flags: review?(ted.mielczarek) → review+
Good question. Looks like it was added to trunk in r60174 back in Dec 16 2002! I am not sure if all the tier2 and tier3 compilers take this option, but we can probably at least simplify the test.

I will push this to fix the immediate problem and open a new bug if needed.
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=b583dad40c36
https://hg.mozilla.org/mozilla-central/rev/b583dad40c36
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.