708075 - the shaped-word caches should be flushed on memory-pressure notification

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Jonathan Kew [:jfkthame]]

The caches for per-font/word shaped glyph data (introduced in bug 703100, replacing gfxTextRunWordCache) should observe the memory-pressure notification and discard cached words when memory is low.

This would have been difficult to do in the old gfxTextRunWordCache world, because of the complex ownership and referencing of the glyph data, but with the per-gfxFont shaped-word caches, it should be simple. This will then allow us to keep shaped-word data in the cache longer for potential re-use, knowing that it will be evicted if necessary.

Comment 1

[Jet Villegas (inactive)]

I love this idea. Do you plan on having this land together with the cache changes, or after?

Comment 2

[Jonathan Kew [:jfkthame]]

No reason we shouldn't land it at the same time, I think - I'll post a patch shortly. It's pretty trivial to implement in the new model.

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: observe memory-pressure notification and discard cached gfxShapedWord records.

Comment 4

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f94f83c7f2df

Comment 5

[Ed Morley [:emorley]]

Backed out of inbound for crashes:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=f94f83c7f2df

https://hg.mozilla.org/integration/mozilla-inbound/rev/76fc8cdd2a31

Comment 6

[Jonathan Kew [:jfkthame]]

Attachment: patch, v2 - observe memory-pressure notification and discard cached gfxShapedWord records

Well, that lit up the tree like it's still Christmas.

This patch passes try without complaint :) .... marking for re-review as it's somewhat restructured from the previous version.

Comment 7

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6290daa65189

Comment 8

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/6290daa65189