[XUL Syntax] Add -moz-box-orient to CSS

RESOLVED FIXED in mozilla1.0

Status

()

Core
XUL
RESOLVED FIXED
17 years ago
9 years ago

People

(Reporter: David Hyatt, Assigned: David Hyatt)

Tracking

Trunk
mozilla1.0
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [XUL1.0])

Attachments

(3 attachments)

(Assignee)

Description

17 years ago
Move box orientation into CSS.
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Whiteboard: [XUL1.0]
Target Milestone: --- → mozilla1.0
(Assignee)

Updated

17 years ago
Blocks: 70753

Updated

17 years ago
OS: Windows 2000 → All
(Assignee)

Comment 1

17 years ago
Created attachment 26731 [details] [diff] [review]
Patch to layout DLL
(Assignee)

Comment 2

17 years ago
Created attachment 26733 [details] [diff] [review]
Patch to content DLL
(Assignee)

Comment 3

17 years ago
Created attachment 26734 [details] [diff] [review]
Patch to xul.css, moving default orientations into CSS
(Assignee)

Comment 4

17 years ago
Ok, this is ready for review.  The subsequent patches to add the remaining six 
properties will be a lot smaller, since this first one adds the new XUL struct 
to the style context and the CSS declaration.

attinasi and brendan, wanna do the honors again? Thanks!  

Note that this code is largely a cut and paste job, exactly emulating the way 
the other structs are defined.  If there's something you don't like about the 
conventions used, etc., please don't blame me, since I'm just blending in. :)
(Assignee)

Comment 5

17 years ago
Also note that we have slated that #ifdef INCLUDE_XUL be made to work for 
real.  That is bug 69995.  I was very meticulous about the #ifdefs.
(Assignee)

Comment 6

17 years ago
cc'ing pierre also for review.

Comment 7

17 years ago
[s]r=attinasi. That's a heck of a migration...
(Assignee)

Comment 8

17 years ago
We will also need this struct for a new CSS property that Bill Law needs for
making the application icons skinnable.  -moz-window-icon.  His bug will be
marked dependent on this one, so that he knows when the XUL struct has gone in.

Updated

17 years ago
Blocks: 57576
r=brendan@mozilla.org.

/be
No longer blocks: 57576
(Assignee)

Comment 10

17 years ago
Fixed.
Blocks: 57576
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
(Assignee)

Updated

17 years ago
No longer blocks: 57576
Seems like the Bugzilla bug hit this - the bug was marked resolved but not
resolved fixed. I'll reopen and mark it fixed for good (I hope).
Status: RESOLVED → REOPENED
Resolved FIXED.
Status: REOPENED → RESOLVED
Last Resolved: 17 years ago17 years ago
Resolution: --- → FIXED

Updated

9 years ago
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.