Closed Bug 708109 Opened 8 years ago Closed 8 years ago

Eliminate THEBES_INLINE_DECL_THREADSAFE_REFCOUNTING

Categories

(Core :: Graphics, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: roc, Assigned: roc)

References

Details

Attachments

(1 file)

NS_INLINE_DECL_THREADSAFE_REFCOUNTING has been added, so we should eliminate THEBES_INLINE_DECL_THREADSAFE_REFCOUNTING.
Comment on attachment 579478 [details] [diff] [review]
fix

Review of attachment 579478 [details] [diff] [review]:
-----------------------------------------------------------------

These AddRef and Release are NS_METHOD_, which is pretty weird in thebes and layers. I don't know if it's a huge issue in practice, but I think we should be aware of this. I'll r- for now; please reflag for review if you think it's ok.
Attachment #579478 - Flags: review?(joe) → review-
Comment on attachment 579478 [details] [diff] [review]
fix

Review of attachment 579478 [details] [diff] [review]:
-----------------------------------------------------------------

I don't see that it matters.
Attachment #579478 - Flags: review- → review?
Comment on attachment 579478 [details] [diff] [review]
fix

Review of attachment 579478 [details] [diff] [review]:
-----------------------------------------------------------------

I don't see that it matters.
Attachment #579478 - Flags: review? → review?(joe)
It might matter if this added significantly to the dependency of layers on XPCOM, but that dependency is already pretty large.
Comment on attachment 579478 [details] [diff] [review]
fix

Review of attachment 579478 [details] [diff] [review]:
-----------------------------------------------------------------

I only mentioned it because it also changes the calling convention of AddRef and Release, but it's not a big deal, you're right.
Attachment #579478 - Flags: review?(joe) → review+
https://hg.mozilla.org/mozilla-central/rev/4be841d52b5b
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.