Eliminate THEBES_INLINE_DECL_THREADSAFE_REFCOUNTING

RESOLVED FIXED in mozilla11

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: roc, Assigned: roc)

Tracking

Trunk
mozilla11
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

NS_INLINE_DECL_THREADSAFE_REFCOUNTING has been added, so we should eliminate THEBES_INLINE_DECL_THREADSAFE_REFCOUNTING.
Created attachment 579478 [details] [diff] [review]
fix
Attachment #579478 - Flags: review?(joe)
Comment on attachment 579478 [details] [diff] [review]
fix

Review of attachment 579478 [details] [diff] [review]:
-----------------------------------------------------------------

These AddRef and Release are NS_METHOD_, which is pretty weird in thebes and layers. I don't know if it's a huge issue in practice, but I think we should be aware of this. I'll r- for now; please reflag for review if you think it's ok.
Attachment #579478 - Flags: review?(joe) → review-
Comment on attachment 579478 [details] [diff] [review]
fix

Review of attachment 579478 [details] [diff] [review]:
-----------------------------------------------------------------

I don't see that it matters.
Attachment #579478 - Flags: review- → review?
Comment on attachment 579478 [details] [diff] [review]
fix

Review of attachment 579478 [details] [diff] [review]:
-----------------------------------------------------------------

I don't see that it matters.
Attachment #579478 - Flags: review? → review?(joe)
It might matter if this added significantly to the dependency of layers on XPCOM, but that dependency is already pretty large.
Comment on attachment 579478 [details] [diff] [review]
fix

Review of attachment 579478 [details] [diff] [review]:
-----------------------------------------------------------------

I only mentioned it because it also changes the calling convention of AddRef and Release, but it's not a big deal, you're right.
Attachment #579478 - Flags: review?(joe) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/4be841d52b5b
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/4be841d52b5b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.