The default bug view has changed. See this FAQ.

Factor out video frame update logic

RESOLVED FIXED in mozilla13

Status

()

Core
Audio/Video
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: roc, Assigned: roc)

Tracking

Trunk
mozilla13
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

Currently nsMediaDecoder/nsBuiltinDecoder have logic for setting the current video frame and updating the current video frame intrinsic size, triggering reflows and invalidation.

This needs to be factored out so that it can be used when the media element doesn't have a decoder, e.g. when it's playing a MediaStream.
Created attachment 579483 [details] [diff] [review]
fix

This introduces a new nsVideoFrameContainer object to manage the "current video frame" state of a video element.
Created attachment 596894 [details] [diff] [review]
fix v2
Attachment #579483 - Attachment is obsolete: true
Attachment #596894 - Flags: review?(chris.double)
Created attachment 596895 [details] [diff] [review]
fix v3

rename to mozilla::VideoFrameContainer.
Attachment #596894 - Attachment is obsolete: true
Attachment #596894 - Flags: review?(chris.double)
Attachment #596895 - Flags: review?(chris.double)
Created attachment 596953 [details] [diff] [review]
fix v4

Merged in some extra changes from my media-streams branch. Basically just need to keep a pointer to the element in the class.
Attachment #596895 - Attachment is obsolete: true
Attachment #596895 - Flags: review?(chris.double)
Attachment #596953 - Flags: review?(chris.double)

Comment 5

5 years ago
Comment on attachment 596953 [details] [diff] [review]
fix v4

License headers for new files should probably use the new boilerplate?

http://www.mozilla.org/MPL/headers/
Attachment #596953 - Flags: review?(chris.double) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/681b168e9528
https://hg.mozilla.org/mozilla-central/rev/681b168e9528
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.