708153 - Provide build option for maintenance service

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P1)

Description

[Brian R. Bondy [:bbondy]]

Attachment: build config patch v1.

Provide the ability to optionally build the maintenance service.

The option should be opt-in, but always defined for Firefox if on Windows and running an x86 build.

The code using this new define is in bug 481815.

Comment 1

[Robert Strong (they/them - no direct email)]

Comment on attachment 579554 [details] [diff] [review]
build config patch v1.

Looks good but I'd like Ted to give this a once over.

Ted, this patch is so apps other than Firefox won't build the maintenance service (bug 481815) when we land it. If at all possible we would like to land bug 481815 on Wednesday (12/7) so if you can review it as soon as you are able it would be appreciated. Thanks!

Comment 2

[Brian R. Bondy [:bbondy]]

Attachment: build config patch v2.

Needed a:
:%s/MOZ_MAINTENANCE_SERVICER/MOZ_MAINTENANCE_SERVICE/

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 579560 [details] [diff] [review]
build config patch v2.

khuey said he could get to this today.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 579560 [details] [diff] [review]
build config patch v2.

Review of attachment 579560 [details] [diff] [review]:
-----------------------------------------------------------------

Do we really need an actual configure option?  Is having a variable that can be set in confvars.sh enough?

Comment 5

[Robert Strong (they/them - no direct email)]

It might be but I'd like developers to be able to easily enable and disable this option for their own builds.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 579560 [details] [diff] [review]
build config patch v2.

Ok, I'll go along with it.

Comment 7

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/mozilla-central/rev/1bd9f069576e