Provide build option for maintenance service

RESOLVED FIXED in mozilla12

Status

()

defect
P1
normal
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: bbondy, Assigned: bbondy)

Tracking

unspecified
mozilla12
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch build config patch v1. (obsolete) — Splinter Review
Provide the ability to optionally build the maintenance service.

The option should be opt-in, but always defined for Firefox if on Windows and running an x86 build.

The code using this new define is in bug 481815.
Attachment #579554 - Flags: review?(robert.bugzilla)
Comment on attachment 579554 [details] [diff] [review]
build config patch v1.

Looks good but I'd like Ted to give this a once over.

Ted, this patch is so apps other than Firefox won't build the maintenance service (bug 481815) when we land it. If at all possible we would like to land bug 481815 on Wednesday (12/7) so if you can review it as soon as you are able it would be appreciated. Thanks!
Attachment #579554 - Flags: review?(ted.mielczarek)
Needed a:
:%s/MOZ_MAINTENANCE_SERVICER/MOZ_MAINTENANCE_SERVICE/
Attachment #579554 - Attachment is obsolete: true
Attachment #579554 - Flags: review?(ted.mielczarek)
Attachment #579554 - Flags: review?(robert.bugzilla)
Attachment #579560 - Flags: review?(robert.bugzilla)
Attachment #579560 - Flags: review?(ted.mielczarek)
Attachment #579560 - Flags: review?(robert.bugzilla) → review+
Comment on attachment 579560 [details] [diff] [review]
build config patch v2.

khuey said he could get to this today.
Attachment #579560 - Flags: review?(ted.mielczarek) → review?(khuey)
Comment on attachment 579560 [details] [diff] [review]
build config patch v2.

Review of attachment 579560 [details] [diff] [review]:
-----------------------------------------------------------------

Do we really need an actual configure option?  Is having a variable that can be set in confvars.sh enough?
It might be but I'd like developers to be able to easily enable and disable this option for their own builds.
Comment on attachment 579560 [details] [diff] [review]
build config patch v2.

Ok, I'll go along with it.
Attachment #579560 - Flags: review?(khuey) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: mozilla11 → mozilla12
You need to log in before you can comment on or make changes to this bug.