708167 - Don't load OpenGL until we're ready to pan and zoom

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect, P1)

Comment 1

[Chris Peterson [:cpeterson]]

dougt, after first run, how often will users launch to about:home instead of saved tabs? Is optimizing about:home worthwhile?

Comment 2

[:Margaret Leibovic]

(In reply to Chris Peterson (:cpeterson) from comment #1)
> dougt, after first run, how often will users launch to about:home instead of
> saved tabs? Is optimizing about:home worthwhile?

Depending on the outcome of bug 719195, we may end up launching to about:home more often.

Comment 3

[Chris Peterson [:cpeterson]]

I don't see any measurable difference between about:home vs previous-tab startup time, with or without postponed initialization of PlaceholderLayerClient.

I will revisit this bug after bug 719195 has been fixed.

Comment 4

[Doug Turner (:dougt)]

chris, how are you measuring and on what phone?

Comment 5

[Chris Peterson [:cpeterson]]

I measured the time to "Gecko:Ready" event when loading about:home on my Galaxy Nexus. Is this an appropriate benchmark?

I commented out the initialization of mPlaceholderLayerClient in GeckoApp.onCreate() and measured the time from launch to the "Gecko:Ready" event (where mPlaceholderLayerClient would be swapped out for mSoftwareLayerClient).

When mPlaceholderLayerClient is initialized, time to Gecko:Ready is about 1900 ms. When mPlaceholderLayerClient is not initialized, time to Gecko:Ready is about 1800 ms.

Comment 6

[Chris Peterson [:cpeterson]]

I tested some slower devices. Kindle Fire benefits from skipping PlaceholderLayerClient initilization, but other devices do not.

"PHLC" == PlaceholderLayerClient initialization.

Device          With PHLC   Without PHLC    Speedup
------          ---------   ------------    -------
Kindle Fire     1970 ms     1670 ms         1.18x :)
Galaxy Nexus    1880 ms     1800 ms         1.04x :)
Droid Pro       2130 ms     2230 ms         0.95x :(
Galaxy S2       1110 ms     1350 ms         0.82x :(

Comment 7

[Chris Peterson [:cpeterson]]

> "PHLC" == PlaceholderLayerClient initialization.

Clarification: the table lists time to "Gecko:Ready" event when PlaceholderLayerClient is used or not.

Comment 8

[Chris Peterson [:cpeterson]]

The above timing numbers are invalid. I discovered that Fennec currently saves empty screenshots, so PlaceholderLayerClient initialization is currently a no-op. I filed bug 723251 to track that issue.

Comment 9

[Chris Peterson [:cpeterson]]

Attachment: bug-708167-part-1-break-PlaceholderLayerClient-GeckoApp-circular-dependency.path

Comment 10

[Chris Peterson [:cpeterson]]

Attachment: bug-708167-part-2-skip-PlaceHolderLayerClient.patch

Comment 11

[Chris Peterson [:cpeterson]]

Attachment: bug-708167-part-1-break-PlaceholderLayerClient-GeckoApp-circular-dependency-v2.patch

patch v2: rebase and minimize changes.

Comment 12

[Chris Peterson [:cpeterson]]

Attachment: bug-708167-part-2-skip-PlaceHolderLayerClient-v2.patch

patch v2: rebase and minimize changes.

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Since this touches PlaceholderLayerClient extensively I'd prefer to see it land on maple to avoid merging/rebasing nightmares later.