Closed Bug 708173 Opened 8 years ago Closed 8 years ago

Use cancelRequestAnimationFrame where appropriate instead of boolean flags

Categories

(Toolkit :: XUL Widgets, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

Spun off from bug 647518 for the third patch in that bug.
Depends on: 647518
Whiteboard: [need review]
Attachment #579578 - Flags: review?(gavin.sharp) → review?(dao)
Comment on attachment 579578 [details] [diff] [review]
Use cancelRequestAnimationCallback instead of tracking booleans in scrollbox code.

>+          if (!this.requestHandle) {
>+            this.requestHandle = window.mozRequestAnimationFrame(this);
>           }

non-imperative nit: prevailing style in this file (and my personal preference) is to not wrap single lines in { }

>+          window.mozCancelRequestAnimationFrame(this.requestHandle);

Ugh, "cancel request animation frame"? I somehow expected cancelAnimationFrameRequest.
Attachment #579578 - Flags: review?(dao) → review+
Component: General → XUL Widgets
OS: Mac OS X → All
QA Contact: general → xul.widgets
Hardware: x86 → All
Whiteboard: [need review]
> Ugh, "cancel request animation frame"?

I actually raised that as a spec issue a few hours ago, because that was my reaction too.  I suggested either cancelAnimationFrame or cancelAnimationFrameRequest.  ;)

I'll remove the curlies.
Whiteboard: [need landing]
https://hg.mozilla.org/integration/mozilla-inbound/rev/70963acaf123
Flags: in-testsuite-
Priority: -- → P3
Whiteboard: [need landing]
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/70963acaf123
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.