708173 - Use cancelRequestAnimationFrame where appropriate instead of boolean flags

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

Spun off from bug 647518 for the third patch in that bug.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Use cancelRequestAnimationCallback instead of tracking booleans in scrollbox code.

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 579578 [details] [diff] [review]
Use cancelRequestAnimationCallback instead of tracking booleans in scrollbox code.

>+          if (!this.requestHandle) {
>+            this.requestHandle = window.mozRequestAnimationFrame(this);
>           }

non-imperative nit: prevailing style in this file (and my personal preference) is to not wrap single lines in { }

>+          window.mozCancelRequestAnimationFrame(this.requestHandle);

Ugh, "cancel request animation frame"? I somehow expected cancelAnimationFrameRequest.

Comment 3

[Boris Zbarsky [:bzbarsky]]

> Ugh, "cancel request animation frame"?

I actually raised that as a spec issue a few hours ago, because that was my reaction too.  I suggested either cancelAnimationFrame or cancelAnimationFrameRequest.  ;)

I'll remove the curlies.

Comment 4

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/70963acaf123

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/70963acaf123