Last Comment Bug 708191 - Don't draw when the screen is off on gonk
: Don't draw when the screen is off on gonk
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Widget (show other bugs)
: Trunk
: All Gonk (Firefox OS)
-- normal (vote)
: mozilla12
Assigned To: Michael Wu [:mwu]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-06 23:16 PST by Michael Wu [:mwu]
Modified: 2012-01-19 02:53 PST (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Don't draw when the screen is off (969 bytes, patch)
2012-01-05 14:54 PST, Michael Wu [:mwu]
cjones.bugs: review+
Details | Diff | Splinter Review
Don't draw when the screen is off, v2 (911 bytes, patch)
2012-01-17 05:15 PST, Michael Wu [:mwu]
cjones.bugs: review+
Details | Diff | Splinter Review

Description User image Michael Wu [:mwu] 2011-12-06 23:16:20 PST
This would help us avoid the "E/gralloc ( 3017): S3CFB_SET_VSYNC_INT enable failed" errors.
Comment 1 User image Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-12-11 08:35:44 PST
+1
Comment 2 User image Michael Wu [:mwu] 2012-01-05 14:54:20 PST
Created attachment 586233 [details] [diff] [review]
Don't draw when the screen is off
Comment 3 User image Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-01-05 16:28:26 PST
Comment on attachment 586233 [details] [diff] [review]
Don't draw when the screen is off

We're going to need to ensure we recomposite (and probably invalidate) the entire screen when we power back on, but this is a step in the right direction.  Please file a followup.
Comment 4 User image Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-01-05 16:35:42 PST
Also, we should deactivate all windows when the screen goes off.  That should incidentally prevent them from attempting to repaint as well.  ("should")  We still want this patch to deal with race conditions.
Comment 5 User image Michael Wu [:mwu] 2012-01-05 16:49:57 PST
(In reply to Chris Jones [:cjones] [:warhammer] from comment #4)
> Also, we should deactivate all windows when the screen goes off.  That
> should incidentally prevent them from attempting to repaint as well. 
> ("should")  We still want this patch to deal with race conditions.

Deactivating windows (by sending the deactivate event) doesn't stop invalidate calls AFAICT. That's why I removed the LOG("  parent isn't top window, bailing"); logging in invalidate.
Comment 6 User image Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-01-05 17:21:29 PST
Alright.  I may be thinking of docShell.active or something like that.  We'll of course need to do that work in followup too.
Comment 7 User image Michael Wu [:mwu] 2012-01-17 05:15:28 PST
Created attachment 589158 [details] [diff] [review]
Don't draw when the screen is off, v2

This version postpones draws until the screen turns back on to make sure things are redrawn if needed.
Comment 9 User image Marco Bonardo [::mak] 2012-01-19 02:53:21 PST
https://hg.mozilla.org/mozilla-central/rev/80d20ea83b92

Note You need to log in before you can comment on or make changes to this bug.