Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Don't draw when the screen is off on gonk

RESOLVED FIXED in mozilla12

Status

()

Core
Widget
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mwu, Assigned: mwu)

Tracking

Trunk
mozilla12
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
This would help us avoid the "E/gralloc ( 3017): S3CFB_SET_VSYNC_INT enable failed" errors.
+1
(Assignee)

Comment 2

6 years ago
Created attachment 586233 [details] [diff] [review]
Don't draw when the screen is off
Assignee: nobody → mwu
Attachment #586233 - Flags: review?(jones.chris.g)
Comment on attachment 586233 [details] [diff] [review]
Don't draw when the screen is off

We're going to need to ensure we recomposite (and probably invalidate) the entire screen when we power back on, but this is a step in the right direction.  Please file a followup.
Attachment #586233 - Flags: review?(jones.chris.g) → review+
Also, we should deactivate all windows when the screen goes off.  That should incidentally prevent them from attempting to repaint as well.  ("should")  We still want this patch to deal with race conditions.
(Assignee)

Comment 5

6 years ago
(In reply to Chris Jones [:cjones] [:warhammer] from comment #4)
> Also, we should deactivate all windows when the screen goes off.  That
> should incidentally prevent them from attempting to repaint as well. 
> ("should")  We still want this patch to deal with race conditions.

Deactivating windows (by sending the deactivate event) doesn't stop invalidate calls AFAICT. That's why I removed the LOG("  parent isn't top window, bailing"); logging in invalidate.
Alright.  I may be thinking of docShell.active or something like that.  We'll of course need to do that work in followup too.
(Assignee)

Comment 7

6 years ago
Created attachment 589158 [details] [diff] [review]
Don't draw when the screen is off, v2

This version postpones draws until the screen turns back on to make sure things are redrawn if needed.
Attachment #586233 - Attachment is obsolete: true
Attachment #589158 - Flags: review?(jones.chris.g)
Attachment #589158 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 8

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/80d20ea83b92
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/80d20ea83b92
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.